Re: [PATCH v3 0/4] Maintenance IV: Platform-specific background maintenance

[Derrick Stolee <stolee@gmail.com>]

On 11/14/2020 4:23 AM, Eric Sunshine wrote:
> On Fri, Nov 13, 2020 at 03:47:15PM -0500, Eric Sunshine wrote:
>> I forgot to mention a couple things when reviewing the patches
>> individually, so I'll point them out here...
> 
> In v2, you added an `xmllint` check on MacOS after discovering that
> gc.c was generating a malformed .plist file on that platform. That got
> me thinking that it would have been nice to have caught the problem
> earlier, if possible, even without having access to MacOS. Since none
> of the code added to gc.c has a hard platform dependency, it should be
> possible to perform all the tests on any platform rather than
> restricting them to specific platforms via test prerequisites. The
> patch below, which is built atop v3, does just that. It removes the
> conditional compilation directives from gc.c and the prerequisites
> from the test script so that all scheduler-specific code in gc.c is
> tested on all platform.
> 
> The changes made by the patch are intended to be folded into each of
> your patches where appropriate (rather than existing atop your series,
> which, though possible, would be ugly). If you're interested in
> incorporating any of these improvements into v4, you can have my
> "Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>" in addition
> to the Helped-by: you already added.

This approach is fascinating. I will tease it apart to appropriately
incorporate it into my series. Thank you for your sign-off, since
this elevates the patches from "Helped-by" to "Co-authored by".

Thanks,
-Stolee