* [PATCH] doc: move git-rev-parse from porcelain to plumbing
@ 2018-10-10 21:37 Daniels Umanovskis
2018-10-10 22:26 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Daniels Umanovskis @ 2018-10-10 21:37 UTC (permalink / raw)
To: git; +Cc: Daniels Umanovskis
git-rev-parse mostly seems like plumbing, and is more usd in
scripts than in regular use. Online it's often mentioned as
a plumbing command. Nonetheless it's listed under porcelain
interrogators in `man git`. It seems appropriate to formally
move git-rev-parse to plumbing interrogators.
Signed-off-by: Daniels Umanovskis <daniels@umanovskis.se>
---
command-list.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/command-list.txt b/command-list.txt
index c36ea3c18..e6364e167 100644
--- a/command-list.txt
+++ b/command-list.txt
@@ -153,7 +153,7 @@ git-rerere ancillaryinterrogators
git-reset mainporcelain worktree
git-revert mainporcelain
git-rev-list plumbinginterrogators
-git-rev-parse ancillaryinterrogators
+git-rev-parse plumbinginterrogators
git-rm mainporcelain worktree
git-send-email foreignscminterface complete
git-send-pack synchingrepositories
--
2.19.1.330.g93276587c.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing
2018-10-10 21:37 [PATCH] doc: move git-rev-parse from porcelain to plumbing Daniels Umanovskis
@ 2018-10-10 22:26 ` Junio C Hamano
2018-10-10 22:56 ` Daniels Umanovskis
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2018-10-10 22:26 UTC (permalink / raw)
To: Daniels Umanovskis; +Cc: git
Daniels Umanovskis <daniels@umanovskis.se> writes:
> git-rev-parse mostly seems like plumbing, and is more usd in
> scripts than in regular use. Online it's often mentioned as
> a plumbing command. Nonetheless it's listed under porcelain
> interrogators in `man git`. It seems appropriate to formally
> move git-rev-parse to plumbing interrogators.
Correct. "ancillary" category ended up with full of Porcelain, it
seems, but there still are plumbing commands there, and this is a
prime example that should not be mixed up with Porcelain commands.
Among the remaining ones in the list, cherry and get-tar-commit-id
are probably better classified as plumbing. I do not know why
cherry is marked for completion; perhaps some crazy people use that
on the command line?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing
2018-10-10 22:26 ` Junio C Hamano
@ 2018-10-10 22:56 ` Daniels Umanovskis
2018-10-10 23:40 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Daniels Umanovskis @ 2018-10-10 22:56 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On 10/11/18 12:26 AM, Junio C Hamano wrote:
> Among the remaining ones in the list, cherry and get-tar-commit-id
> are probably better classified as plumbing. I do not know why
> cherry is marked for completion; perhaps some crazy people use that
> on the command line?
I think cherry could go either way, get-tar-commit-id is definitely
plumbing. Would you like me to fix those two on the same patch then?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing
2018-10-10 22:56 ` Daniels Umanovskis
@ 2018-10-10 23:40 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2018-10-10 23:40 UTC (permalink / raw)
To: Daniels Umanovskis; +Cc: git
Daniels Umanovskis <daniels@umanovskis.se> writes:
> On 10/11/18 12:26 AM, Junio C Hamano wrote:
>> Among the remaining ones in the list, cherry and get-tar-commit-id
>> are probably better classified as plumbing. I do not know why
>> cherry is marked for completion; perhaps some crazy people use that
>> on the command line?
>
> I think cherry could go either way, get-tar-commit-id is definitely
> plumbing. Would you like me to fix those two on the same patch then?
No, what you sent for rev-parse is already good. A separate patch
that addresses other ones can be discussed as an orthogonal matter.
It even may deserve to make them two separate patches, as I
anticipate that some people would resist marking "cherry" as
plumbing, so that only one can be applied while dropping the other
as/if needed.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-10 23:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 21:37 [PATCH] doc: move git-rev-parse from porcelain to plumbing Daniels Umanovskis
2018-10-10 22:26 ` Junio C Hamano
2018-10-10 22:56 ` Daniels Umanovskis
2018-10-10 23:40 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).