From: Phillip Wood <phillip.wood@talktalk.net>
To: Alban Gruin <alban.gruin@gmail.com>,
phillip.wood@dunelm.org.uk, git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>,
Christian Couder <christian.couder@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Elijah Newren <newren@gmail.com>
Subject: Re: [GSoC][PATCH 1/1] rebase--interactive: rewrite the edit-todo functionality in C
Date: Tue, 12 Jun 2018 17:20:50 +0100 [thread overview]
Message-ID: <7b9134a2-8e23-e089-0fd3-0e67f384eba0@talktalk.net> (raw)
In-Reply-To: <801da146-6905-5f7b-12c0-7239108b6207@gmail.com>
Hi Alban
On 12/06/18 13:33, Alban Gruin wrote:
> Hi Phillip,
>
> Le 11/06/2018 à 17:32, Phillip Wood a écrit :
>>> + if (launch_editor(todo_file, NULL, NULL))
>>
>> I'm not sure that this will respect GIT_SEQUENCE_EDITOR, it would be
>> nice to have a launch_sequence_editor() function that shared as much
>> code as possible with launch_editor()
>>
>
> It could be done by making launch_editor() and launch_sequence_editor()
> some kind of wrapper around a function like launch_specified_editor()
> (or something like that), that would take the editor as a parameter, in
> addition to the path, the buffer and environment variables. It would be
> also very trivial to implement your first point above on top of that.
That sounds like a good way forward, launch_sequence_editor() could just
call launch_editor() if GIT_SEQUENCE_EDITOR and sequence.editor are not set.
>>> int append_todo_help(unsigned edit_todo, unsigned keep_empty);
>>
>> Can this declaration be removed now?
>
> No, it’s still used in rebase--helper.c for now.
Ah, sorry I missed that
Best Wishes
Phillip
>
>>
>>> +int edit_todo_list(unsigned flags);
>>> int skip_unnecessary_picks(void);
>>> int rearrange_squash(void);
>>
>> Best Wishes
>>
>> Phillip
>>
>
> Cheers,
> Alban
>
next prev parent reply other threads:[~2018-06-12 16:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 13:57 [GSoC][PATCH 0/1] rebase -i: rewrite the edit-todo functionality in C Alban Gruin
2018-06-11 13:57 ` [GSoC][PATCH 1/1] rebase--interactive: " Alban Gruin
2018-06-11 15:32 ` Phillip Wood
2018-06-12 12:33 ` Alban Gruin
2018-06-12 16:20 ` Phillip Wood [this message]
2018-06-12 15:46 ` Elijah Newren
2018-06-12 16:11 ` Alban Gruin
2018-06-13 15:22 ` [GSoC][PATCH v2 0/2] rebase -i: " Alban Gruin
2018-06-13 15:22 ` [GSoC][PATCH v2 1/2] editor: add a function to launch the sequence editor Alban Gruin
2018-06-13 15:22 ` [GSoC][PATCH v2 2/2] rebase--interactive: rewrite the edit-todo functionality in C Alban Gruin
2018-06-14 20:14 ` Junio C Hamano
2018-06-14 20:24 ` Alban Gruin
2018-06-14 20:42 ` Elijah Newren
2018-06-14 9:53 ` [GSoC][PATCH v2 0/2] rebase -i: " Phillip Wood
2018-06-26 16:21 ` [GSoC][PATCH v3 " Alban Gruin
2018-06-26 16:21 ` [GSoC][PATCH v3 1/2] editor: add a function to launch the sequence editor Alban Gruin
2018-06-26 16:21 ` [GSoC][PATCH v3 2/2] rebase-interactive: rewrite the edit-todo functionality in C Alban Gruin
2018-06-26 21:47 ` Johannes Schindelin
2018-06-26 21:45 ` [GSoC][PATCH v3 0/2] rebase -i: " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b9134a2-8e23-e089-0fd3-0e67f384eba0@talktalk.net \
--to=phillip.wood@talktalk.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=alban.gruin@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).