git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
* [PATCH 0/1] t1308-config-set: fix a test that has a typo
@ 2019-10-10 12:35 Johannes Schindelin via GitGitGadget
  2019-10-10 12:35 ` [PATCH 1/1] " Tanay Abhra via GitGitGadget
  0 siblings, 1 reply; 4+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2019-10-10 12:35 UTC (permalink / raw)
  To: git; +Cc: Johannes Schindelin, Junio C Hamano

I am currently trying to whittle down the number of open PRs at 
https://github.com/git/git, and this is one of the patches I deem valuable
enough (and complete enough) to put through to the Git mailing list even
when the original contributor has gone silent.

Tanay Abhra (1):
  t1308-config-set: fix a test that has a typo

 t/t1308-config-set.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


base-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-387%2Fdscho%2Fconfig-set-test-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-387/dscho/config-set-test-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/387
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] t1308-config-set: fix a test that has a typo
  2019-10-10 12:35 [PATCH 0/1] t1308-config-set: fix a test that has a typo Johannes Schindelin via GitGitGadget
@ 2019-10-10 12:35 ` " Tanay Abhra via GitGitGadget
  2019-10-10 20:48   ` Johannes Schindelin
  0 siblings, 1 reply; 4+ messages in thread
From: Tanay Abhra via GitGitGadget @ 2019-10-10 12:35 UTC (permalink / raw)
  To: git; +Cc: Johannes Schindelin, Junio C Hamano, Tanay Abhra

From: Tanay Abhra <tanayabh@gmail.com>

Change test 'find value_list for a key from a configset' to redirect the
result to 'expect' instead of 'except' which was a typo.

With this change, the test case actually fails because it uses
`configset_get_value`. Clearly, this was intended to be
`configset_get_value_multi` since the test expects a list of values
instead of a single value, so let's fix that, too.

Originally contributed as https://github.com/git/git/pull/451.

Signed-off-by: Tanay Abhra <tanayabh@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t1308-config-set.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
index d0a2727b85..7b4e1a63eb 100755
--- a/t/t1308-config-set.sh
+++ b/t/t1308-config-set.sh
@@ -166,14 +166,14 @@ test_expect_success 'find value with highest priority from a configset' '
 '
 
 test_expect_success 'find value_list for a key from a configset' '
-	cat >except <<-\EOF &&
+	cat >expect <<-\EOF &&
+	lama
+	ball
 	sam
 	bat
 	hask
-	lama
-	ball
 	EOF
-	test-tool config configset_get_value case.baz config2 .git/config >actual &&
+	test-tool config configset_get_value_multi case.baz config2 .git/config >actual &&
 	test_cmp expect actual
 '
 
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] t1308-config-set: fix a test that has a typo
  2019-10-10 12:35 ` [PATCH 1/1] " Tanay Abhra via GitGitGadget
@ 2019-10-10 20:48   ` Johannes Schindelin
  2019-10-11  5:35     ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Johannes Schindelin @ 2019-10-10 20:48 UTC (permalink / raw)
  To: Tanay Abhra via GitGitGadget; +Cc: git, Junio C Hamano, Tanay Abhra

Team,

On Thu, 10 Oct 2019, Tanay Abhra via GitGitGadget wrote:

> diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
> index d0a2727b85..7b4e1a63eb 100755
> --- a/t/t1308-config-set.sh
> +++ b/t/t1308-config-set.sh
> @@ -166,14 +166,14 @@ test_expect_success 'find value with highest priority from a configset' '
>  '
>
>  test_expect_success 'find value_list for a key from a configset' '
> -	cat >except <<-\EOF &&
> +	cat >expect <<-\EOF &&

I should note that I looked through all of the hits of `git grep -w
except -- t/` and did not find any other typo.

Thanks,
Johannes

> +	lama
> +	ball
>  	sam
>  	bat
>  	hask
> -	lama
> -	ball
>  	EOF
> -	test-tool config configset_get_value case.baz config2 .git/config >actual &&
> +	test-tool config configset_get_value_multi case.baz config2 .git/config >actual &&
>  	test_cmp expect actual
>  '
>
> --
> gitgitgadget
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] t1308-config-set: fix a test that has a typo
  2019-10-10 20:48   ` Johannes Schindelin
@ 2019-10-11  5:35     ` Junio C Hamano
  0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2019-10-11  5:35 UTC (permalink / raw)
  To: Johannes Schindelin; +Cc: Tanay Abhra via GitGitGadget, git, Tanay Abhra

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> I should note that I looked through all of the hits of `git grep -w
> except -- t/` and did not find any other typo.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 12:35 [PATCH 0/1] t1308-config-set: fix a test that has a typo Johannes Schindelin via GitGitGadget
2019-10-10 12:35 ` [PATCH 1/1] " Tanay Abhra via GitGitGadget
2019-10-10 20:48   ` Johannes Schindelin
2019-10-11  5:35     ` Junio C Hamano

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox