From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 51BB01F9FE for ; Sat, 24 Jul 2021 22:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbhGXV03 (ORCPT ); Sat, 24 Jul 2021 17:26:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbhGXV01 (ORCPT ); Sat, 24 Jul 2021 17:26:27 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFDA1C061575 for ; Sat, 24 Jul 2021 15:06:58 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id n12so2778388wrr.2 for ; Sat, 24 Jul 2021 15:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=4sbo9L3WyEzpnZVRXoNExIO8xlbAV5n42dZGsSUqv5Y=; b=YLbiozst+Dx+hxrDjL9MgQeZ5M7XdbzhO5+2LVrhLvg6HZWVGnwQSSZAZxC6McqKpa NEVOu/P0PA7d4thoNrGGg0+wIpifPwVqanstpa/HEZm8Kk+tTychmuvUy+jM2fNwiQGj S3lmd097QwJdHPkJNMWbSGznpjL+KAh88iNAruqEKykIHvxuVJ3w6QiWbTmwTaoHnEZ3 raW5BMgg/z/beASZTdBuDbdvn8MCyISn/lp/y55uH2kCi/Vzp6yuXutZ+fEqAJoaesNg blmi1Gber0fGrmDGi4lFg6Wp57+m73r2j3+5jjR+m8wwCNGrNKwUGt+ZPTb655d6tRi7 rq5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=4sbo9L3WyEzpnZVRXoNExIO8xlbAV5n42dZGsSUqv5Y=; b=JrRopYLrjYJOM1DtxsPmx4jKQZJ+jAFQqvWhK6BA3sfXW0PVpkxGZMrRhdpdl9nHVX r09XnVLCK+XTZ9VTzDsO05nX0LUUlK9B2n5A5Wfs3aCYXjFwA5GVPn1VqsRwPLNQEKt5 Iv+8q4JivTBFsfwGrAa+pLtdgm3qlueqIB7o6GOoHWtWtm7quTAfN1YKnqy/uDiGsu9c MMr/DhdWtKe8d9XI/glYR2DBpSsT69nBc7QIjKpVBkvXuzuw1mIodlEtLy8qxvaRVay4 NOCv/b+GxzFqBplottgpHTI5BGaDWGZZv3u/42IdZ7vnVMSJ3mKYcklQwEXbT4nIWwlf 26zA== X-Gm-Message-State: AOAM533yJ/IBORDKYfWYgb0wysLaf9JkuQw1mbHG2GH0TkAERusgJa8a SCV1u2Jx2/R3f/UvMSIZUrzUbORcyug= X-Google-Smtp-Source: ABdhPJzf9RZbb+f7wpAXS9a21Yn68tEC3PPnV4awiS3pDErpYy9faMESncA/WFj+saVXayag/DdlKQ== X-Received: by 2002:adf:f50e:: with SMTP id q14mr11509582wro.183.1627164417399; Sat, 24 Jul 2021 15:06:57 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id s24sm39397781wra.33.2021.07.24.15.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 15:06:57 -0700 (PDT) Message-Id: <7b79ba66dd0d43f2565d2cbba268f01d3d36d052.1627164413.git.gitgitgadget@gmail.com> In-Reply-To: References: From: "Johannes Schindelin via GitGitGadget" Date: Sat, 24 Jul 2021 22:06:51 +0000 Subject: [PATCH v3 3/5] expand_user_path(): clarify the role of the `real_home` parameter Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Ramsay Jones , Duy Nguyen , Junio C Hamano , Johannes Sixt , Jeff King , Eric Sunshine , Johannes Schindelin , Johannes Schindelin Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Johannes Schindelin The `real_home` parameter only has an effect when expanding paths starting with `~/`, not when expanding paths starting with `~/`. Let's make that clear. Signed-off-by: Johannes Schindelin --- path.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/path.c b/path.c index 3318ad24336..bf329e535cf 100644 --- a/path.c +++ b/path.c @@ -722,7 +722,7 @@ static struct passwd *getpw_str(const char *username, size_t len) * Return a string with ~ and ~user expanded via getpw*. Returns NULL on getpw * failure or if path is NULL. * - * If real_home is true, strbuf_realpath($HOME) is used in the expansion. + * If real_home is true, strbuf_realpath($HOME) is used in the `~/` expansion. */ char *expand_user_path(const char *path, int real_home) { -- gitgitgadget