From: Johannes Sixt <j6t@kdbg.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Carlos Pita" <carlosjosepita@gmail.com>
Cc: "“git@vger.kernel.org”" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: Index files autocompletion too slow in big repositories (w / suggestion for improvement)
Date: Sat, 15 Apr 2017 13:59:34 +0200 [thread overview]
Message-ID: <7a07a2a8-07a6-4342-80d0-7684e6242326@kdbg.org> (raw)
In-Reply-To: <CACBZZX7Ajf1c9YKP=MO0T9SV7d0-XZsT=RthJocqZw4_TcCcQw@mail.gmail.com>
Cc Gábor.
Am 15.04.2017 um 00:33 schrieb Ævar Arnfjörð Bjarmason:
> On Sat, Apr 15, 2017 at 12:08 AM, Carlos Pita <carlosjosepita@gmail.com> wrote:
>> This is much faster (below 0.1s):
>>
>> __git_index_files ()
>> {
>> local dir="$(__gitdir)" root="${2-.}" file;
>> if [ -d "$dir" ]; then
>> __git_ls_files_helper "$root" "$1" | \
>> sed -r 's@/.*@@' | uniq | sort | uniq
>> fi
>> }
>>
>> time __git_index_files
>>
>> real 0m0.075s
>> user 0m0.083s
>> sys 0m0.010s
>>
>> Most of the improvement is due to the simpler, non-grouping, regex.
>> Since I expect most of the common prefixes to arrive consecutively,
>> running uniq before sort also improves things a bit. I'm not removing
>> leading double quotes anymore (this isn't being done by the current
>> version, anyway) but this doesn't seem to hurt.
>>
>> Despite the dependence on sed this is ten times faster than the
>> original, maybe an option to enable fast index completion or something
>> like that might be desirable.
>
> It's fine to depend on sed, these shell-scripts are POSIX compatible,
> and so is sed, we use sed in a lot of the built-in shellscripts.
This is about command line completion. We go a long way to avoid forking
processes there. What is 10x faster on Linux despite of forking a
process may not be so on Windows.
(I'm not using bash command line completion on Windows, so I can't tell
what the effect of your suggested change is on Windows. I hope Gábor can
comment on it.)
-- Hannes
next prev parent reply other threads:[~2017-04-15 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 20:06 Index files autocompletion too slow in big repositories (w / suggestion for improvement) Carlos Pita
2017-04-14 22:08 ` Carlos Pita
2017-04-14 22:33 ` Ævar Arnfjörð Bjarmason
2017-04-15 1:37 ` Jacob Keller
2017-04-15 7:52 ` Junio C Hamano
2017-04-15 11:59 ` Johannes Sixt [this message]
2017-04-16 0:31 ` Jacob Keller
2017-04-17 4:05 ` Junio C Hamano
2017-04-17 8:03 ` Johannes Sixt
2017-04-15 12:30 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a07a2a8-07a6-4342-80d0-7684e6242326@kdbg.org \
--to=j6t@kdbg.org \
--cc=avarab@gmail.com \
--cc=carlosjosepita@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).