From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B678D1F66E for ; Mon, 17 Aug 2020 13:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728421AbgHQNWy (ORCPT ); Mon, 17 Aug 2020 09:22:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728274AbgHQNWx (ORCPT ); Mon, 17 Aug 2020 09:22:53 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD271C061389 for ; Mon, 17 Aug 2020 06:22:52 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id w2so7704152qvh.12 for ; Mon, 17 Aug 2020 06:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HS/bGMx8Rdqto/aWN4LX3DfwwXJk3h+p4ZRykHu7Kds=; b=XytbWfq0qECSfKltQaIFGT5G/PSdadlzFPWjOPKvyQsSoQFc9fFOSiNlWXaEQ/9JyE G8oJqd3AVLmWPQKT8Mpd/irLDTh5x/A2N1YvT9vSiSJDu36YVnHq4Ve0wJ4pTkTM9WKT qZQyoKB7xSCme1+KaSb1YjSiKNoA5JMzGMu2ob92TaIgu1piW6/Oo/PJ+ZAT8IRtShnt ilHCTBJDZM1VteyooepN7wouACfmUNR00XxxwQ9Pu3+ZTG120PhigoUl3Mf9ao+FVmMz +8BdbKVoLwEEqAd3fF8PUco1jJRXBTXZ6d51UnaRPLhXuupqHQGFuXDwu6H+sQR0OUEJ PeRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HS/bGMx8Rdqto/aWN4LX3DfwwXJk3h+p4ZRykHu7Kds=; b=jvtjchfeR+hphmlNuXQN4TY/lNlL44ZNH658RLw+lC+DPNiEAIXqetEK924DSVqW+P 9afZ/v7paeF5X622pdQYV7O5B7+3RriAdrUE3iTsHjaZEjaiF4rz/bBXPy1+JL2ke7xD blbqpNUaAKzCdapwmgGmDFUsoGnOPnMt2l73jvY4nfwYmxDi86Q+j2Dp0hVy0irYOI6x TlJwh/Dp3phCd7X43SberEtBzsKyUJxK7r5wptS4OWBnZCoxOjzqJW7T+yfnmmST2chq 9YCVlyK5sPdb7wmUKGJZZQBFwrRrdDBnv9hxP8S7+JGtVY2jniFJz46qboLWO61P++Kl heyg== X-Gm-Message-State: AOAM531WGyoor1EedabyWRKJj3gBgWQ8xLbqKXF9YIu5BG2aoyrEHl7h sfpdjo9ZQrLRHUNgX76kocmyFncvISYFLw== X-Google-Smtp-Source: ABdhPJwgKuWw4N83Hz5w8Q1JbPHSoMLC5PY37x5cHFav20ZFCzWejY+U0EXk5/o/C07qV2vyqhd2aw== X-Received: by 2002:a0c:f9cd:: with SMTP id j13mr14062308qvo.227.1597670568449; Mon, 17 Aug 2020 06:22:48 -0700 (PDT) Received: from ?IPv6:2600:1700:e72:80a0:28bb:588:e45a:f44b? ([2600:1700:e72:80a0:28bb:588:e45a:f44b]) by smtp.gmail.com with ESMTPSA id s30sm19987924qtc.87.2020.08.17.06.22.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2020 06:22:47 -0700 (PDT) Subject: Re: [PATCH v3 04/11] commit-graph: consolidate compare_commits_by_gen To: Abhishek Kumar via GitGitGadget , git@vger.kernel.org Cc: =?UTF-8?Q?Jakub_Nar=c4=99bski?= , Taylor Blau , Abhishek Kumar References: <6a0cde983d9ed20f043a4977313d714154602012.1597509583.git.gitgitgadget@gmail.com> From: Derrick Stolee Message-ID: <79ab9d8c-9767-430a-9744-01fa81bdf9bc@gmail.com> Date: Mon, 17 Aug 2020 09:22:46 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <6a0cde983d9ed20f043a4977313d714154602012.1597509583.git.gitgitgadget@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 8/15/2020 12:39 PM, Abhishek Kumar via GitGitGadget wrote: > From: Abhishek Kumar > > Comparing commits by generation has been independently defined twice, in > commit-reach and commit. Let's simplify the implementation by moving > compare_commits_by_gen() to commit-graph. > > Signed-off-by: Abhishek Kumar > Reviewed-by: Taylor Blau > Signed-off-by: Abhishek Kumar Whoops! Be sure to add the "Reviewed-by: above the "Signed-off-by" line(s) so re-signing off doesn't add a duplicate like this. Thanks, -Stolee