From: Kenneth Lorber <keni@his.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Kenneth Lorber <keni@his.com>
Subject: Re: [RFC PATCH v2 1/6] doc: Tell the glossary about core.hooksPath
Date: Wed, 27 May 2020 12:52:25 -0400 [thread overview]
Message-ID: <79C90EFA-CF65-4AF7-82B2-0B1B6FABA0F8@his.com> (raw)
In-Reply-To: <xmqqmu5umsjg.fsf@gitster.c.googlers.com>
> On May 26, 2020, at 2:59 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> Kenneth Lorber <keni@his.com> writes:
>
>> Subject: Re: [RFC PATCH v2 1/6] doc: Tell the glossary about core.hooksPath
>
> Perhaps
>
> Subject: [PATCH] glossary: describe core.hooksPath
>
> Please separate this one patch out and send it again without the
> rest of the series, as this is quite different from the rest of the
> 6-patch series and an obvious clarification, unlike the others.
Will do.
>
>> - operation is done. The hook scripts are found in the
>> - `$GIT_DIR/hooks/` directory, and are enabled by simply
>> - removing the `.sample` suffix from the filename. In earlier versions
>> - of Git you had to make them executable.
>> + operation is done. The hook scripts are found in `$GIT_DIR/hooks/`
>
> You accidentally lost 'the', and because you did an unnecessary
> line-wrapping, such a change became harder to spot.
My apologies.
>
> I am not sure if .sample scripts should be a topioc of this glossary
> entry at all to begin with. And I think it outlived the usefulness
> to describe what was in versions of Git that is more than 10 years
> old. I wonder if it is a better idea to take your new description,
> but remove everything after "The sample scripts are enabled..."
> except for the "see ... for details" link?
I had considered it but didn't want to presume. If I don't hear any objections
I will take it out.
>
>> + or in any directory specified by the `core.hooksPath` configuration
>> + variable. The sample scripts are enabled by simply
>> + removing the `.sample` suffix from the filename. In earlier versions
>> + of Git you had to make the sample scripts executable manually.
>> + Hook scripts must be executable. See linkgit:githooks[5] for details.
>
>> [[def_index]]index::
>> A collection of files with stat information, whose contents are stored
next prev parent reply other threads:[~2020-05-27 17:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 2:13 [RFC PATCH 0/6] various documentation bits Kenneth Lorber
2020-05-17 2:13 ` [RFC PATCH 1/6] Tell the glossary about core.hooksPath Kenneth Lorber
2020-05-17 18:33 ` Junio C Hamano
2020-05-18 22:06 ` Kenneth Lorber
2020-05-17 2:13 ` [RFC PATCH 2/6] Add bit on extending git to Hacking Git Kenneth Lorber
2020-05-17 18:34 ` Junio C Hamano
2020-05-18 22:10 ` Kenneth Lorber
2020-05-17 2:13 ` [RFC PATCH 3/6] Add namespace collision avoidance guidelines file Kenneth Lorber
2020-05-17 9:45 ` Abhishek Kumar
2020-05-18 15:51 ` Kenneth Lorber
2020-05-17 15:31 ` Junio C Hamano
2020-05-18 21:46 ` Kenneth Lorber
2020-05-17 2:13 ` [RFC PATCH 4/6] Include NAMESPACE COLLISIONS doc into gitrepository-layout.txt Kenneth Lorber
2020-05-18 0:26 ` Junio C Hamano
2020-05-18 23:54 ` Kenneth Lorber
2020-05-17 2:13 ` [RFC PATCH 5/6] Tell config.txt about NAMESPACE COLLISIONS Kenneth Lorber
2020-05-18 0:32 ` Junio C Hamano
2020-05-17 2:13 ` [RFC PATCH 6/6] Add NAMESPACE COLLISIONS reference to Hacking Git Kenneth Lorber
2020-05-17 7:42 ` [RFC PATCH 0/6] various documentation bits Abhishek Kumar
2020-05-17 18:39 ` Junio C Hamano
2020-05-18 23:44 ` Kenneth Lorber
2020-05-18 15:45 ` Kenneth Lorber
2020-05-25 23:27 ` [RFC PATCH v2 " Kenneth Lorber
2020-05-25 23:27 ` [RFC PATCH v2 1/6] doc: Tell the glossary about core.hooksPath Kenneth Lorber
2020-05-26 18:59 ` Junio C Hamano
2020-05-27 16:52 ` Kenneth Lorber [this message]
2020-05-27 17:18 ` Kenneth Lorber
2020-05-27 17:18 ` Junio C Hamano
2020-05-25 23:27 ` [RFC PATCH v2 2/6] doc: Add bit on extending git to Hacking Git Kenneth Lorber
2020-05-25 23:27 ` [RFC PATCH v2 3/6] doc: Add namespace collision guidelines file Kenneth Lorber
2020-05-28 18:49 ` Junio C Hamano
2020-05-28 19:29 ` Junio C Hamano
2020-05-29 1:20 ` Junio C Hamano
2020-05-29 18:08 ` Junio C Hamano
2020-06-01 23:55 ` Kenneth Lorber
2020-06-01 18:38 ` Kenneth Lorber
2020-05-25 23:27 ` [RFC PATCH v2 4/6] doc: Add collision doc to gitrepository-layout.txt Kenneth Lorber
2020-05-25 23:27 ` [RFC PATCH v2 5/6] doc: Tell config.txt about namespace collisions Kenneth Lorber
2020-05-25 23:27 ` [RFC PATCH v2 6/6] doc: Add collision reference to Hacking Git Kenneth Lorber
2020-05-31 21:37 ` [RFC PATCH 0/2] update glossary hooks entry Kenneth Lorber
2020-05-31 21:37 ` [RFC PATCH 1/2] doc: Tell the glossary about core.hooksPath Kenneth Lorber
2020-05-31 21:37 ` [RFC PATCH 2/2] doc: remove dated info and refs to sample hooks Kenneth Lorber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79C90EFA-CF65-4AF7-82B2-0B1B6FABA0F8@his.com \
--to=keni@his.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).