From: Derrick Stolee <stolee@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Junio C Hamano <gitster@pobox.com>
Cc: GIT Mailing-list <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] ewah: delete unused 'rlwit_discharge_empty()'
Date: Tue, 19 Jun 2018 19:49:00 -0400 [thread overview]
Message-ID: <795ca948-1633-a1f7-1d7c-88ace8361445@gmail.com> (raw)
In-Reply-To: <7bfb528f-ef65-4de6-7d01-6ca91f0072e7@ramsayjones.plus.com>
On 6/19/2018 5:51 PM, Ramsay Jones wrote:
> From: Junio C Hamano <gitster@pobox.com>
>
> Complete the removal of unused 'ewah bitmap' code by removing the now
> unused 'rlwit_discharge_empty()' function. Also, the 'ewah_clear()'
> function can now be made a file-scope static symbol.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Junio,
>
> Can you please add this to the 'ds/ewah-cleanup' branch, before
> we forget to do so! ;-)
>
> Thanks!
>
> ATB,
> Ramsay Jones
Looks good to me! Thanks!
-Stolee
>
> ewah/ewah_bitmap.c | 20 ++++++++++++--------
> ewah/ewah_rlw.c | 8 --------
> ewah/ewok.h | 6 ------
> ewah/ewok_rlw.h | 1 -
> 4 files changed, 12 insertions(+), 23 deletions(-)
>
> diff --git a/ewah/ewah_bitmap.c b/ewah/ewah_bitmap.c
> index 017c677f9..d59b1afe3 100644
> --- a/ewah/ewah_bitmap.c
> +++ b/ewah/ewah_bitmap.c
> @@ -276,6 +276,18 @@ void ewah_each_bit(struct ewah_bitmap *self, void (*callback)(size_t, void*), vo
> }
> }
>
> +/**
> + * Clear all the bits in the bitmap. Does not free or resize
> + * memory.
> + */
> +static void ewah_clear(struct ewah_bitmap *self)
> +{
> + self->buffer_size = 1;
> + self->buffer[0] = 0;
> + self->bit_size = 0;
> + self->rlw = self->buffer;
> +}
> +
> struct ewah_bitmap *ewah_new(void)
> {
> struct ewah_bitmap *self;
> @@ -288,14 +300,6 @@ struct ewah_bitmap *ewah_new(void)
> return self;
> }
>
> -void ewah_clear(struct ewah_bitmap *self)
> -{
> - self->buffer_size = 1;
> - self->buffer[0] = 0;
> - self->bit_size = 0;
> - self->rlw = self->buffer;
> -}
> -
> void ewah_free(struct ewah_bitmap *self)
> {
> if (!self)
> diff --git a/ewah/ewah_rlw.c b/ewah/ewah_rlw.c
> index b9643b7d0..5093d43e2 100644
> --- a/ewah/ewah_rlw.c
> +++ b/ewah/ewah_rlw.c
> @@ -104,11 +104,3 @@ size_t rlwit_discharge(
>
> return index;
> }
> -
> -void rlwit_discharge_empty(struct rlw_iterator *it, struct ewah_bitmap *out)
> -{
> - while (rlwit_word_size(it) > 0) {
> - ewah_add_empty_words(out, 0, rlwit_word_size(it));
> - rlwit_discard_first_words(it, rlwit_word_size(it));
> - }
> -}
> diff --git a/ewah/ewok.h b/ewah/ewok.h
> index 0c504f28e..84b2a29fa 100644
> --- a/ewah/ewok.h
> +++ b/ewah/ewok.h
> @@ -72,12 +72,6 @@ void ewah_pool_free(struct ewah_bitmap *self);
> */
> struct ewah_bitmap *ewah_new(void);
>
> -/**
> - * Clear all the bits in the bitmap. Does not free or resize
> - * memory.
> - */
> -void ewah_clear(struct ewah_bitmap *self);
> -
> /**
> * Free all the memory of the bitmap
> */
> diff --git a/ewah/ewok_rlw.h b/ewah/ewok_rlw.h
> index bb3c6ff7e..7cdfdd0c0 100644
> --- a/ewah/ewok_rlw.h
> +++ b/ewah/ewok_rlw.h
> @@ -98,7 +98,6 @@ void rlwit_init(struct rlw_iterator *it, struct ewah_bitmap *bitmap);
> void rlwit_discard_first_words(struct rlw_iterator *it, size_t x);
> size_t rlwit_discharge(
> struct rlw_iterator *it, struct ewah_bitmap *out, size_t max, int negate);
> -void rlwit_discharge_empty(struct rlw_iterator *it, struct ewah_bitmap *out);
>
> static inline size_t rlwit_word_size(struct rlw_iterator *it)
> {
next prev parent reply other threads:[~2018-06-19 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 21:51 [PATCH] ewah: delete unused 'rlwit_discharge_empty()' Ramsay Jones
2018-06-19 23:49 ` Derrick Stolee [this message]
2018-06-21 16:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=795ca948-1633-a1f7-1d7c-88ace8361445@gmail.com \
--to=stolee@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).