From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7244B1F9E5 for ; Thu, 1 Apr 2021 01:51:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233119AbhDABud (ORCPT ); Wed, 31 Mar 2021 21:50:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233024AbhDABuL (ORCPT ); Wed, 31 Mar 2021 21:50:11 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 658E3C061764 for ; Wed, 31 Mar 2021 18:50:11 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id j9so166923wrx.12 for ; Wed, 31 Mar 2021 18:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=63cgv+d6hF7bJxk9XJMcdXLWzyM+y2aIDW1QZ5VUN1A=; b=A7m9rt6w4Hg8Pe/0RAnlaW4T04G2vGCJtMz+qDFfycG8RmVzJz4n0PVn5HRI/TOqH0 flHy9R6CxbimC7w+vitU9QAQzjajxlSKq13slmau+nyEDPTEYF5qxAlr0191cHU6Wny+ WLEkIF5Mt7zC8LAXt7gI4FkI9f05PKtnribZkItQZ++yiTbaLNJKS2uaQWibKo6grF2g yc4VH5OkW467OSR+ymukNk7Q01Rb659hqHqOpjhGHZeWmi5WRxwfHscm3v65r8seuKFY rpUU5+h66liIdX08plYszx1pYLSUwau8QV/nvsYaD7UilVk0NgpVa59yqYBs49kg25I6 454Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=63cgv+d6hF7bJxk9XJMcdXLWzyM+y2aIDW1QZ5VUN1A=; b=QFi90t1N777mdNflzlMWReXb9eyXY3wTiStbrcKcOwPRm+iYL2h4GBVIYVycXNWIJK Kk1JBBora3zw2qimgL2O7rvMXb4QNjIzIcs2pMNSwbfFibsaj102FH04Gx/yr+t76MUt kW5pO6JC0WuR5TM/Ho0XzLIZxGG4Js+7XMa1vHhwrDt0fOYE4VNH0DCl0xFkJwJ+dAHg MBsiE10M4O4ki+k3JMGl6xj+Yz1sjoWulC9wAQSLP+7SEhgte+uLF4oRwigjyKup+VeB X2h9JvphdBICiZ7AZYhpkZKaUf7cMbPFd+uYzBExVFjzeh69e8xGRaLIpBBQ16Yrymom doxQ== X-Gm-Message-State: AOAM530aRYtnZxFM34jpCVet1B95OOJFg5i8O3anNx8JKGEaB+x7axHW eHsADoufxmhuV9sqmiBajoX/KKgwrTY= X-Google-Smtp-Source: ABdhPJzVCgnJ1cuMPfvzkMmeOZyFWDiacepj6qPOd2kFsQRX7OtmBpHvUDFAx42M6fG8HCxPltq/fw== X-Received: by 2002:adf:e4c7:: with SMTP id v7mr6701076wrm.245.1617241810254; Wed, 31 Mar 2021 18:50:10 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id a6sm7783968wmm.0.2021.03.31.18.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 18:50:09 -0700 (PDT) Message-Id: <779a86ad1ec46f53ae38b17cb53df347b01576fe.1617241803.git.gitgitgadget@gmail.com> In-Reply-To: References: From: "Derrick Stolee via GitGitGadget" Date: Thu, 01 Apr 2021 01:49:47 +0000 Subject: [PATCH v2 10/25] fsck: ensure full index Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: newren@gmail.com, gitster@pobox.com, Derrick Stolee , Matheus Tavares Bernardino , Derrick Stolee , Derrick Stolee Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Derrick Stolee When verifying all blobs reachable from the index, ensure that a sparse index has been expanded to a full one to avoid missing some blobs. Signed-off-by: Derrick Stolee --- builtin/fsck.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/fsck.c b/builtin/fsck.c index 821e7798c706..4d7f5c63ce0d 100644 --- a/builtin/fsck.c +++ b/builtin/fsck.c @@ -883,6 +883,8 @@ int cmd_fsck(int argc, const char **argv, const char *prefix) verify_index_checksum = 1; verify_ce_order = 1; read_cache(); + /* TODO: audit for interaction with sparse-index. */ + ensure_full_index(&the_index); for (i = 0; i < active_nr; i++) { unsigned int mode; struct blob *blob; -- gitgitgadget