From: Patryk Obara <patryk.obara@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH 08/12] pack-write: switch various SHA-1 values to abstract forms
Date: Sun, 28 Jan 2018 21:30:36 +0100 [thread overview]
Message-ID: <76f6c291-9c48-279d-3bb6-fc42a8e0eb9b@gmail.com> (raw)
In-Reply-To: <20180128155722.880805-9-sandals@crustytoothpaste.net>
On 28/01/2018 16:57, brian m. carlson wrote:
> if (partial_pack_offset == 0) {
> - unsigned char sha1[20];
> - git_SHA1_Final(sha1, &old_sha1_ctx);
> - if (hashcmp(sha1, partial_pack_sha1) != 0)
> + unsigned char hash[GIT_MAX_RAWSZ];
> + the_hash_algo->final_fn(hash, &old_hash_ctx);
> + if (hashcmp(hash, partial_pack_hash) != 0)
Maybe "hash" should be struct object_id here?
> char *index_pack_lockfile(int ip_out)
> {
> - char packname[46];
> + char packname[GIT_MAX_HEXSZ + 6];
> + int len = the_hash_algo->hexsz + 6;
Just me nitpicking, but "len" can be const :)
--
| ← Ceci n'est pas une pipe
Patryk Obara
next prev parent reply other threads:[~2018-01-28 20:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 15:57 [PATCH 00/12] object_id part 11 (the_hash_algo) brian m. carlson
2018-01-28 15:57 ` [PATCH 01/12] hash: move SHA-1 macros to hash.h brian m. carlson
2018-01-28 15:57 ` [PATCH 02/12] hash: create union for hash context allocation brian m. carlson
2018-01-28 19:57 ` Patryk Obara
2018-01-28 20:16 ` brian m. carlson
2018-01-28 15:57 ` [PATCH 03/12] builtin/index-pack: improve hash function abstraction brian m. carlson
2018-01-28 15:57 ` [PATCH 04/12] builtin/unpack-objects: switch uses of SHA-1 to the_hash_algo brian m. carlson
2018-01-28 15:57 ` [PATCH 05/12] sha1_file: " brian m. carlson
2018-01-28 15:57 ` [PATCH 06/12] fast-import: switch various " brian m. carlson
2018-01-28 20:10 ` Patryk Obara
2018-01-28 15:57 ` [PATCH 07/12] pack-check: convert various uses of SHA-1 to abstract forms brian m. carlson
2018-01-28 15:57 ` [PATCH 08/12] pack-write: switch various SHA-1 values " brian m. carlson
2018-01-28 20:30 ` Patryk Obara [this message]
2018-01-28 21:52 ` brian m. carlson
2018-01-28 15:57 ` [PATCH 09/12] read-cache: abstract away uses of SHA-1 brian m. carlson
2018-01-28 19:50 ` Eric Sunshine
2018-01-28 20:10 ` brian m. carlson
2018-01-28 15:57 ` [PATCH 10/12] csum-file: rename sha1file to hashfile brian m. carlson
2018-01-28 15:57 ` [PATCH 11/12] csum-file: abstract uses of SHA-1 brian m. carlson
2018-01-28 15:57 ` [PATCH 12/12] bulk-checkin: abstract SHA-1 usage brian m. carlson
2018-01-28 20:48 ` [PATCH 00/12] object_id part 11 (the_hash_algo) Patryk Obara
2018-01-28 22:00 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76f6c291-9c48-279d-3bb6-fc42a8e0eb9b@gmail.com \
--to=patryk.obara@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).