From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: sg/commit-graph-cleanups (was Re: What's cooking in git.git (Jun 2020, #03; Wed, 17))
Date: Thu, 18 Jun 2020 09:32:34 -0400 [thread overview]
Message-ID: <76f63479-c142-86f2-c045-f802f7794a7d@gmail.com> (raw)
In-Reply-To: <xmqqpn9wq3tl.fsf@gitster.c.googlers.com>
On 6/18/2020 2:35 AM, Junio C Hamano wrote:
> * sg/commit-graph-cleanups (2020-06-17) 18 commits
You have this topic marked with "Code cleanup" which is definitely
true of the first submission, but not the second.
> - commit-graph: persist existence of changed-paths
> - commit-graph: change test to die on parse, not load
These two add an important behavior change to persist the changed-paths
after a user opts-in to using them.
> - bloom: enforce a minimum size of 8 bytes
> - commit-graph: check all leading directories in changed path Bloom filters
These two have meaningful performance gains.
> - commit-graph: check chunk sizes after writing
> - commit-graph: simplify chunk writes into loop
> - commit-graph: unify the signatures of all write_graph_chunk_*() functions
> - commit-graph: place bloom_settings in context
These four (from the second series) _are_ cleanups, but were harder to
apply than the others from the first series.
> - commit-graph: simplify write_commit_graph_file() #2
> - commit-graph: simplify write_commit_graph_file() #1
> - commit-graph: simplify parse_commit_graph() #2
> - commit-graph: simplify parse_commit_graph() #1
> - commit-graph: clean up #includes
> - diff.h: drop diff_tree_oid() & friends' return value
> - commit-slab: add a function to deep free entries on the slab
> - commit-graph-format.txt: all multi-byte numbers are in network byte order
> - commit-graph: fix parsing the Chunk Lookup table
> - tree-walk.c: don't match submodule entries for 'submod/anything'
These are all cleanups from the first series.
In summary, if you would like to keep these together as a single
topic, then perhaps this summary might be good:
The changed-path Bloom filter is improved using ideas from
an independent implementation.
Thanks,
-Stolee
next prev parent reply other threads:[~2020-06-18 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 6:35 What's cooking in git.git (Jun 2020, #03; Wed, 17) Junio C Hamano
2020-06-18 8:44 ` Denton Liu
2020-06-18 13:32 ` Derrick Stolee [this message]
2020-06-18 16:18 ` sg/commit-graph-cleanups (was Re: What's cooking in git.git (Jun 2020, #03; Wed, 17)) Junio C Hamano
2020-06-18 17:55 ` What's cooking in git.git (Jun 2020, #03; Wed, 17) brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76f63479-c142-86f2-c045-f802f7794a7d@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).