From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 5775A1F463 for ; Mon, 9 Sep 2019 19:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732384AbfIITtY (ORCPT ); Mon, 9 Sep 2019 15:49:24 -0400 Received: from siwi.pair.com ([209.68.5.199]:40947 "EHLO siwi.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731191AbfIITtY (ORCPT ); Mon, 9 Sep 2019 15:49:24 -0400 Received: from siwi.pair.com (localhost [127.0.0.1]) by siwi.pair.com (Postfix) with ESMTP id 902713F40BC; Mon, 9 Sep 2019 15:49:23 -0400 (EDT) Received: from [IPv6:2001:4898:6808:13e:6099:d0b3:95b6:588c] (unknown [IPv6:2001:4898:a800:1012:11cd:d0b3:95b6:588c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by siwi.pair.com (Postfix) with ESMTPSA id 164D53F4088; Mon, 9 Sep 2019 15:49:23 -0400 (EDT) Subject: Re: [PATCH v3 1/2] list-objects-filter: only parse sparse OID when 'have_git_dir' To: Junio C Hamano Cc: Jeff King , Jeff Hostetler , Jon Simons , git@vger.kernel.org, me@ttaylorr.com, sunshine@sunshineco.com, stolee@gmail.com References: <20190829231925.15223-1-jon@jonsimons.org> <20190829231925.15223-2-jon@jonsimons.org> <20190904045424.GA6488@sigill.intra.peff.net> From: Jeff Hostetler Message-ID: <76c1470c-929e-4116-c0ba-9514b836fb24@jeffhostetler.com> Date: Mon, 9 Sep 2019 15:49:22 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 9/9/2019 1:12 PM, Junio C Hamano wrote: > Jeff Hostetler writes: > >> It would be nice if we could continue to let parse_list_objects_filter() >> do the syntax checking -- that is, we can still check that we received a >> ulong in "blob:limit:" and that "sparse:oid:" looks like a hex >> value, for example. Just save the actual lookup to the higher >> layer, if and when that makes sense. > > Hmmm, am I misremembering things or did I hear somebody mention in > this thread that people give "sparse:oid:master" (not blob object > name in hex, but a refname) and expect the other side to resolve it? > You're right. I misspoke. I was thinking about the hex OID case and forgetting about the : form. Jeff