mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Denton Liu <>
To: Git Mailing List <>,
	Paul Mackerras <>
Cc: Denton Liu <>, Beat Bolli <>
Subject: [PATCH v2 1/2] gitk: drop quotes in copysummary format
Date: Thu, 12 Dec 2019 16:44:49 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

In an earlier commit[1], git learned the 'reference' pretty format. This
format was very similar to the format that copysummary used but it omits
the quotes surrounding the commit's subject. Remove the quotes from the
format in copysummary in order to match the 'reference' pretty format.

It seems the consensus is that the unquoted form is used more often
anyway[2] so this change should be acceptable.

[These commits are in git.git.]
[1]: 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19)
[2]: fb2ffa77a6 (SubmittingPatches: remove dq from commit reference, 2019-11-19)

Signed-off-by: Denton Liu <>
 gitk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gitk b/gitk
index abe4805ade..d07e3302de 100755
--- a/gitk
+++ b/gitk
@@ -9429,7 +9429,7 @@ proc mktaggo {} {
 proc copysummary {} {
     global rowmenuid autosellen
-    set format "%h (\"%s\", %ad)"
+    set format "%h (%s, %ad)"
     set cmd [list git show -s --pretty=format:$format --date=short]
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen

  reply	other threads:[~2019-12-13  0:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 21:39 [PATCH] gitk: use --pretty=reference for copysummary Denton Liu
2019-12-11 21:58 ` Paul Mackerras
2019-12-11 22:05   ` Junio C Hamano
2019-12-13  0:44 ` [PATCH v2 0/2] gitk: match Git's 'reference' pretty format Denton Liu
2019-12-13  0:44   ` Denton Liu [this message]
2019-12-13 17:12     ` [PATCH v2 1/2] gitk: drop quotes in copysummary format Junio C Hamano
2019-12-15  4:19     ` Paul Mackerras
2019-12-13  0:44   ` [PATCH v2 2/2] gitk: rename "commit summary" to "commit reference" Denton Liu
2019-12-13 17:12     ` Junio C Hamano
2019-12-15  4:36     ` Paul Mackerras
2019-12-13 17:04   ` [PATCH v2 0/2] gitk: match Git's 'reference' pretty format Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).