From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.4 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6B7E61F54E for ; Tue, 19 Jul 2022 15:09:44 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=github.com header.i=@github.com header.b="RMr45cVN"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235714AbiGSPJk (ORCPT ); Tue, 19 Jul 2022 11:09:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233681AbiGSPJi (ORCPT ); Tue, 19 Jul 2022 11:09:38 -0400 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE42E509FC for ; Tue, 19 Jul 2022 08:09:37 -0700 (PDT) Received: by mail-oo1-xc35.google.com with SMTP id j1-20020a4ab1c1000000b0043576bcb9b1so2740345ooo.10 for ; Tue, 19 Jul 2022 08:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ire77J7nT2QAGmmQfRfLEXWNHh6H7bXQGSdUIYAEuCg=; b=RMr45cVNTaGkddLa7AiqJMpfq4ExMGPo9QOlkm6kHk9LLxvUXTaBvmY6LKjxVJs38F k6ppJoZLbl++TN2peFdV7Za6kP7i1L6rnhIUJa0Ws0OnXJ2i3wxCtG8Dmq0amDiaFqBP 3GxWDEbBt6besOLO/9YV52zdX+dx6PHlDNhPcVXLSZRcP/HPCPs7gaoLW6bQKTd04z2r Txr/uL+PsiUjnuAZE7/n8QKqIIK5WSH5yEqu1qFhgFLYm4OBGeapclklEBIT5yR24uN0 JC/Zj/Q6qYgFweO9yeaiuXTs5BLkpt8uOGlvDo53lMQNTeh7Ow9I8y7QjyuE2jaIxI+0 BVIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ire77J7nT2QAGmmQfRfLEXWNHh6H7bXQGSdUIYAEuCg=; b=s5xjl6qwWGBk613b4lrXrIc5J/4rIJe/KLk+cFFc7Fg1TTwIZlYplQwyN1iMBWgkp1 t/ewjrbX89VCE8g3ZTJIz0Fw23ge8ytMe9L5P9VdVwaYyoeUF4gved8wF9pyDrD6hMyK p6wZ3UD+QkS3svMQcl7KsnDFtqR89lXMmaf8k0GzaC5IghuKXSXaS1FgcVtMw/tuiiN5 KrtlpUd7TR/clBh6jH8fHrtz786Ou77iCJoImMEwuRMlV55JOeatYC3eagBMjx3xf6cm QDR9tWcaURgzp+uGusoncNqNiE+68yfrCJ8O1ZivIxiKdgLhI1vJBTOq377xQqLA4sQq 9bBQ== X-Gm-Message-State: AJIora+MS0WcIbd5w1cFWrZlVyr31yrMHAw4Rpqwn6DgGEU9pSikBlHa 5C5/qjgmBnDetf0CblbjuqRt X-Google-Smtp-Source: AGRyM1uyOHSScnS8fsgmFW/74KOcMLGdp7oDA28kaMuwVUYjPlL5zZmYzp8j9YY+3OIQZ1CFEN3C0g== X-Received: by 2002:a4a:dccc:0:b0:435:9890:a10 with SMTP id h12-20020a4adccc000000b0043598900a10mr4177053oou.63.1658243377033; Tue, 19 Jul 2022 08:09:37 -0700 (PDT) Received: from ?IPV6:2600:1700:e72:80a0:3950:7a99:4a4a:8622? ([2600:1700:e72:80a0:3950:7a99:4a4a:8622]) by smtp.gmail.com with ESMTPSA id q14-20020a05683022ce00b0061c87262540sm4656683otc.65.2022.07.19.08.09.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jul 2022 08:09:36 -0700 (PDT) Message-ID: <75cc0f43-d9a5-45d3-5e36-dd20acfebf50@github.com> Date: Tue, 19 Jul 2022 11:09:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/3] t/*: avoid "whitelist" Content-Language: en-US To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Derrick Stolee via GitGitGadget Cc: git@vger.kernel.org, gitster@pobox.com, johannes.schindelin@gmx.de, Jeff King References: <3c3c8c20bcb4e570d25a676ad1f29877762adb82.1657852722.git.gitgitgadget@gmail.com> <220715.86o7xqzkt3.gmgdl@evledraar.gmail.com> From: Derrick Stolee In-Reply-To: <220715.86o7xqzkt3.gmgdl@evledraar.gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 7/15/2022 7:02 AM, Ævar Arnfjörð Bjarmason wrote: >> GIT_TEST_PASSING_SANITIZE_LEAK= when compiled with >> -SANITIZE=leak will run only those tests that have whitelisted >> -themselves as passing with no memory leaks. Tests can be whitelisted >> -by setting "TEST_PASSES_SANITIZE_LEAK=true" before sourcing >> -"test-lib.sh" itself at the top of the test script. This test mode is >> -used by the "linux-leaks" CI target. >> +SANITIZE=leak will run only those tests that have marked themselves as >> +passing with no memory leaks by setting "TEST_PASSES_SANITIZE_LEAK=true" >> +before sourcing "test-lib.sh" itself at the top of the test script. This >> +test mode is used by the "linux-leaks" CI target. > > It's hard to improve your own verbage, but I think in this case my > original version can be improved still: > > GIT_TEST_PASSING_SANITIZE_LEAK= when compiled with > SANITIZE=leak will, when true, only run those tests that declare > themselves leak-free by setting "TEST_PASSES_SANITIZE_LEAK=true" > before sourcing "test-lib.sh". This test mode is used by the > "linux-leaks" CI target. Another iteration: GIT_TEST_PASSING_SANITIZE_LEAK= focuses the test suite on finding memory leaks. When the variable is true and Git is compiled with SANITIZE=leak, only run those tests that declare themselves leak-free by setting "TEST_PASSES_SANITIZE_LEAK=true" before sourcing "test-lib.sh". This test mode is used by the "linux-leaks" CI target. >> -test_expect_success 'curl redirects respect whitelist' ' >> +test_expect_success 'curl redirects respect allowed protocols' ' > > Isn't the real problem here that this is inaccurate with regards to > "curl", i.e. AFAIK from browsing transport.c the whitelist of protocols > has nothing to do with curl, we parse that out and apply it before we > ever get to the specific transport layer. > > So this should just be "http(s) transport respects GIT_ALLOW_PROTOCOL", > no? Sounds good. >> -test_description='test protocol whitelisting with submodules' >> +test_description='test protocol restrictions with submodules' > > Minor: I think this shows the awkwardness of using a word derived from > "allow". Before we could use "whitelist" and "whitelisting" > consistentlry, but now you have "allowed", "allowlist", "restrictions" > etc. > > I guess you could say "test protocol allowances..." or something? Meh. Perhaps "filtering" is the best way to describe the higher-level feature that these lists help to implement. Thanks, -Stolee