From: Barret Rhoden <brho@google.com>
To: Michael Platings <michael@platin.gs>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Stefan Beller" <stefanbeller@gmail.com>,
"Jeff Smith" <whydoubt@gmail.com>, "René Scharfe" <l.s.r@web.de>
Subject: Re: [RFC PATCH 0/1] Fuzzy blame
Date: Wed, 3 Apr 2019 11:25:43 -0400 [thread overview]
Message-ID: <7540d14b-f225-39ec-b37e-54cb157d4a72@google.com> (raw)
In-Reply-To: <CAJDYR9R77_+gfOgLXX_Az8iODNRyDTHAT8BAubZeptEWJViYqA@mail.gmail.com>
Hi -
On 3/25/19 7:21 PM, Michael Platings wrote:
>> The first thing that comes to mind for me is to plug your fuzzy logic
>> into my patch set.
> Please do! It should be easy to pluck fuzzy_find_matching_lines() and
> its dependencies out. Just to set your expectations, I have not yet
> optimised it and it is highly wasteful right now both in terms of time
> and memory.
I edited my patch set to allow changing the heuristic. I also made a
commit that uses your fingerprinting code to match target lines to
parent lines. I'll send it all out in another email and CC you. The
last commit is still a work in progress.
Regarding stuff like the name of the ignore file, in my first version, I
went with whatever git hyper-blame does. That was shot down, rightly
so, I think. With a git-config setting, you can name the file whatever
you want, or add multiple files. With my current patchset, you can
disable the file too with --ignore-revs-file="".
As far as using notes or per-commit info, that might be nice, though
it's not a huge burden to have a separate commit - you can wait til
after things get merged (so we have the final object name (hash)) and
it's not hugely burdensome. But I get that's just my opinion. =)
Barret
next prev parent reply other threads:[~2019-04-03 15:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 23:50 [RFC PATCH 0/1] Fuzzy blame michael
2019-03-24 23:50 ` [RFC PATCH 1/1] " michael
2019-03-25 2:39 ` [RFC PATCH 0/1] " Junio C Hamano
2019-03-25 9:32 ` Michael Platings
2019-03-25 16:04 ` Barret Rhoden
2019-03-25 23:21 ` Michael Platings
2019-03-25 23:35 ` Jeff King
2019-03-26 3:07 ` Jacob Keller
2019-03-26 20:26 ` Michael Platings
2019-03-27 6:36 ` Duy Nguyen
2019-03-27 8:26 ` Michael Platings
2019-03-27 9:02 ` Duy Nguyen
2019-04-03 15:25 ` Barret Rhoden [this message]
2019-04-03 21:49 ` Michael Platings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7540d14b-f225-39ec-b37e-54cb157d4a72@google.com \
--to=brho@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=michael@platin.gs \
--cc=peff@peff.net \
--cc=stefanbeller@gmail.com \
--cc=whydoubt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).