From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id B3C9E1F45A for ; Mon, 24 Oct 2022 23:03:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230272AbiJXXDU (ORCPT ); Mon, 24 Oct 2022 19:03:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbiJXXC5 (ORCPT ); Mon, 24 Oct 2022 19:02:57 -0400 Received: from smtp.hosts.co.uk (smtp.hosts.co.uk [85.233.160.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBE61105342 for ; Mon, 24 Oct 2022 14:24:17 -0700 (PDT) Received: from 88-110-102-84.dynamic.dsl.as9105.com ([88.110.102.84] helo=[192.168.1.57]) by smtp.hosts.co.uk with esmtpa (Exim) (envelope-from ) id 1on4v3-0001Sz-8E; Mon, 24 Oct 2022 22:23:37 +0100 Message-ID: <746491f4-fb41-92fe-7360-20a845dc21fc@iee.email> Date: Mon, 24 Oct 2022 22:23:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v2 3/3] glossary: add reachability bitmap description Content-Language: en-GB To: Junio C Hamano , Abhradeep Chakraborty Cc: GitList , Derrick Stolee References: <20221022222539.2333-1-philipoakley@iee.email> <20221022222539.2333-4-philipoakley@iee.email> From: Philip Oakley In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 24/10/2022 17:39, Junio C Hamano wrote: > Abhradeep Chakraborty writes: > >> Small correction here - A repository may have multiple bitmaps (one >> for each selected commit from the preferred packfile or a >> multi-pack-index) but it can have only one ".bitmap" file (as of now). >> Bitmaps for the selected commits are stored in that ".bitmap" file. >> So I think the below lines (or similar) will work - >> >> The bitmaps are stored in a ".bitmap" file. A repository may have >> at most one ".bitmap" file. The file may belong to either one pack, or the >> repository's multi-pack-index (if it exists). >> >> Feel free to rephrase it accordingly. > Sounds good to me. Or Philip's original can be tweaked minimally to > say "... may have at most one bitmap file (which stores multiple > bitmaps)". > Thanks both. I'll tweak the description in a day or so to allow Stolee to comment if required. P.