From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: "Git mailing list" <git@vger.kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] fetch: improve grammar of "shallow roots" message
Date: Thu, 20 May 2021 12:03:36 +0700 [thread overview]
Message-ID: <72f5226c-142a-f4a1-64c6-46ef647adbb5@gmail.com> (raw)
In-Reply-To: <CAMMLpeRxoakadrXUVGSkhP0K71GHXxt4sXvSKrB5rx8oFH60bw@mail.gmail.com>
On 20/05/21 11.02, Alex Henrie wrote:
> On Wed, May 19, 2021 at 8:22 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>>
>> On 18/05/21 13.18, Alex Henrie wrote:
>>
>>> - warning(_("reject %s because shallow roots are not allowed to be updated"),
>>> + warning(_("rejected %s because shallow roots are not allowed to be updated"),
>>
>> From descriptive to null-subject past tense, right?
>
> I'm not sure what the best way is to describe the grammar here. I
> would say that the "ed" makes it clear that the message is a
> description of what did happen rather than an imperative command
> concerning what should happen.
>
> -Alex
>
Looks OK.
So the error had happened, and we needed to express the situation.
Because it happened on the past, using past tense was obviously the
right thing.
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2021-05-20 5:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 6:18 [PATCH] fetch: improve grammar of "shallow roots" message Alex Henrie
2021-05-19 1:17 ` Junio C Hamano
2021-05-19 13:55 ` Derrick Stolee
2021-05-20 2:22 ` Bagas Sanjaya
2021-05-20 4:02 ` Alex Henrie
2021-05-20 5:03 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72f5226c-142a-f4a1-64c6-46ef647adbb5@gmail.com \
--to=bagasdotme@gmail.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).