list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Bagas Sanjaya <>
To: Alex Henrie <>
Cc: "Git mailing list" <>,
	"Nguyễn Thái Ngọc Duy" <>,
	"Junio C Hamano" <>
Subject: Re: [PATCH] fetch: improve grammar of "shallow roots" message
Date: Thu, 20 May 2021 12:03:36 +0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 20/05/21 11.02, Alex Henrie wrote:
> On Wed, May 19, 2021 at 8:22 PM Bagas Sanjaya <> wrote:
>> On 18/05/21 13.18, Alex Henrie wrote:
>>> -                                     warning(_("reject %s because shallow roots are not allowed to be updated"),
>>> +                                     warning(_("rejected %s because shallow roots are not allowed to be updated"),
>>   From descriptive to null-subject past tense, right?
> I'm not sure what the best way is to describe the grammar here. I
> would say that the "ed" makes it clear that the message is a
> description of what did happen rather than an imperative command
> concerning what should happen.
> -Alex

Looks OK.

So the error had happened, and we needed to express the situation.
Because it happened on the past, using past tense was obviously the
right thing.

Reviewed-by: Bagas Sanjaya <>

An old man doll... just what I always wanted! - Clara

      reply	other threads:[~2021-05-20  5:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:18 Alex Henrie
2021-05-19  1:17 ` Junio C Hamano
2021-05-19 13:55 ` Derrick Stolee
2021-05-20  2:22 ` Bagas Sanjaya
2021-05-20  4:02   ` Alex Henrie
2021-05-20  5:03     ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).