git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Sergey Organov <sorganov@gmail.com>,
	Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
	Jakub Narebski <jnareb@gmail.com>,
	Markus Jansen <mja@jansen-preisler.de>,
	Gabriel Alcaras <gabriel.alcaras@telecom-paristech.fr>,
	Jeff King <peff@peff.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Jiang Xin <worldhello.net@gmail.com>,
	Jacob Keller <jacob.keller@gmail.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Igor Djordjevic <igor.d.djordjevic@gmail.com>,
	Johannes Sixt <j6t@kdbg.org>,
	Phillip Wood <phillip.wood@talktalk.net>,
	Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: Draft of Git Rev News edition 38
Date: Mon, 16 Apr 2018 20:37:16 +0530	[thread overview]
Message-ID: <72f42205-c9c6-03aa-e8df-12e7062e8e62@gmail.com> (raw)
In-Reply-To: <87sh7v6vn4.fsf@javad.com>


[-- Attachment #1.1: Type: text/plain, Size: 1520 bytes --]

Hi,

On Monday 16 April 2018 08:33 PM, Sergey Organov wrote:
> Christian Couder <christian.couder@gmail.com> writes:
>> Here "the above article" means the Jake's "branch -l: print useful
>> info whilst rebasing a non-local branch" article above the current
>> article.

Just a little correction. I suppose Chris actually meant the "rebase -i:
offer to recreate merge commits" article written by Jake and not the
"branch -l: print useful info whilst rebasing a non-local branch" article.

That said, I read the draft and found it good except for two minor issues,

1. I see the following sentence in the "Rebasing merges: a jorney to the
ultimate solution (Road Clear) (written by Jacob Keller)" article

	"A few examples were tried, but it was proven that the original
	concept did not work, as dropped commits could end up being
	replaid into the merge commits, turning them into "evil"
	merges."

I'm not sure if 'replaid' is proper English assuming the past tense of
replay was intended there (which I think is 'replayed').


2. I see a minor Markdown syntax issue in the "branch -l: print useful
info whilst rebasing a non-local branch" article.

	... reworked his original patch to improve `git branch
	--list̀

Specifically, in the '--list̀' part. I guess it should be "--list`".

-- 
Kaartic

QUOTE:

“The most valuable person on any team is the person who makes everyone
else on the team more valuable, not the person who knows the most.”

      - Joel Spolsky


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-04-16 15:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-15 22:11 Draft of Git Rev News edition 38 Christian Couder
2018-04-16  8:55 ` Christian Couder
2018-04-16 12:29   ` Sergey Organov
2018-04-16 13:08     ` Christian Couder
2018-04-16 15:03       ` Sergey Organov
2018-04-16 15:07         ` Kaartic Sivaraam [this message]
2018-04-16 15:19           ` Sergey Organov
2018-04-16 22:30             ` Christian Couder
2018-04-17  0:58               ` Jacob Keller
2018-04-16 22:26           ` Christian Couder
2018-04-17  2:17             ` Kaartic Sivaraam
2018-04-17  7:33               ` Christian Couder
2018-04-16 15:52     ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72f42205-c9c6-03aa-e8df-12e7062e8e62@gmail.com \
    --to=kaartic.sivaraam@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=christian.couder@gmail.com \
    --cc=gabriel.alcaras@telecom-paristech.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=igor.d.djordjevic@gmail.com \
    --cc=j6t@kdbg.org \
    --cc=jacob.keller@gmail.com \
    --cc=jnareb@gmail.com \
    --cc=mja@jansen-preisler.de \
    --cc=peff@peff.net \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=phillip.wood@talktalk.net \
    --cc=sorganov@gmail.com \
    --cc=sunshine@sunshineco.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).