git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Matheus Tavares <matheus.bernardino@usp.br>,
	git@vger.kernel.org
Subject: Re: [RFC PATCH] parallel-checkout: send the new object_id algo field to the workers
Date: Mon, 17 May 2021 12:54:21 -0400	[thread overview]
Message-ID: <7182880b-0f1e-7b3e-dc6e-b72c8ddd14b3@gmail.com> (raw)
In-Reply-To: <YJ7VI5kHAAk126YJ@camp.crustytoothpaste.net>

On 5/14/2021 3:53 PM, brian m. carlson wrote:
> On 2021-05-14 at 14:36:00, Matheus Tavares wrote:>>
>> I've read the hash transition plan, but I'm not confident to say that I
>> fully understand it yet, so maybe this patch is not exactly what we need
>> here. Mainly, I'm not sure I understand in which cases we will have an
>> object_id.algo that is not the_hash_algo. Is it for the early transition
>> phases, where we have a SHA-256 repo that accepts user input as SHA-1? 
> 
> Yes, that's correct, as well as for interoperability with remotes using
> a different hash algorithm.
> 
>> Also, the object_id's copied here at send_one_item() always come from a
>> `struct cache_entry`. In this case, can they still have different
>> `algo`s or do we expect them to be the_hash_algo?
> 
> No, things in the index should always use the same algorithm..
> 
> The patch looks fine to me.

Chiming in to say I agree that this is a good patch.

Thanks,
-Stolee

  reply	other threads:[~2021-05-17 16:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 14:36 [RFC PATCH] parallel-checkout: send the new object_id algo field to the workers Matheus Tavares
2021-05-14 19:53 ` brian m. carlson
2021-05-17 16:54   ` Derrick Stolee [this message]
2021-05-17 19:32     ` Junio C Hamano
2021-05-17 19:49 ` [PATCH v2] " Matheus Tavares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7182880b-0f1e-7b3e-dc6e-b72c8ddd14b3@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=matheus.bernardino@usp.br \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).