From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] mingw: allow absolute paths without drive prefix
Date: Thu, 13 Dec 2018 20:38:14 +0100 [thread overview]
Message-ID: <70faf8fb-5e98-9247-9955-71b8fc983567@kdbg.org> (raw)
In-Reply-To: <8efe7938-12a9-7db3-8f95-825ee2e32247@kdbg.org>
Am 13.12.18 um 07:25 schrieb Johannes Sixt:
> Am 13.12.18 um 03:48 schrieb Junio C Hamano:
>> So,... what's the conclusion? The patch in the context of my tree
>> would be a no-op, and we'd need a prerequisite change to the support
>> function to accompany this patch to be effective?
>
> Correct, that is my conclusion.
Moreover, there is no problem with your tree to begin with. I cloned
into a destination without a drive letter:
C:\>git clone R:\j6t\expat.git \Temp\expat
Cloning into '\Temp\expat'...
done.
and it works fine. If I understood the description in patch 1/2
correctly, this should have failed.
-- Hannes
next prev parent reply other threads:[~2018-12-13 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:47 [PATCH 0/2] mingw: support absolute paths without a drive prefix Johannes Schindelin via GitGitGadget
2018-12-10 18:47 ` [PATCH 1/2] mingw: demonstrate a problem with certain absolute paths Johannes Schindelin via GitGitGadget
2018-12-10 18:47 ` [PATCH 2/2] mingw: allow absolute paths without drive prefix Johannes Schindelin via GitGitGadget
2018-12-10 21:58 ` Johannes Sixt
2018-12-11 11:25 ` Johannes Schindelin
2018-12-11 20:36 ` Johannes Sixt
2018-12-13 2:48 ` Junio C Hamano
2018-12-13 6:25 ` Johannes Sixt
2018-12-13 19:38 ` Johannes Sixt [this message]
2018-12-14 11:31 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70faf8fb-5e98-9247-9955-71b8fc983567@kdbg.org \
--to=j6t@kdbg.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).