From: Johannes Sixt <j6t@kdbg.org>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()
Date: Mon, 30 Apr 2018 21:32:44 +0200 [thread overview]
Message-ID: <7087f0b9-1362-f8ca-315d-96d27b91b26b@kdbg.org> (raw)
In-Reply-To: <9bbfd73a8e03a888a5e9e8800d853ece518a8bf5.1525040253.git.johannes.schindelin@gmx.de>
Am 30.04.2018 um 00:17 schrieb Johannes Schindelin:
> t1406 specifically verifies that certain code paths fail with a BUG: ...
> message.
>
> In the upcoming commit, we will convert that message to be generated via
> BUG() instead of die("BUG: ..."), which implies SIGABRT instead of a
> regular exit code.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> t/t1406-submodule-ref-store.sh | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/t/t1406-submodule-ref-store.sh b/t/t1406-submodule-ref-store.sh
> index e093782cc37..0ea3457cae3 100755
> --- a/t/t1406-submodule-ref-store.sh
> +++ b/t/t1406-submodule-ref-store.sh
> @@ -16,7 +16,7 @@ test_expect_success 'setup' '
> '
>
> test_expect_success 'pack_refs() not allowed' '
> - test_must_fail $RUN pack-refs 3
> + test_must_fail ok=sigabrt $RUN pack-refs 3
> '
>
> test_expect_success 'peel_ref(new-tag)' '
> @@ -27,15 +27,18 @@ test_expect_success 'peel_ref(new-tag)' '
> '
>
> test_expect_success 'create_symref() not allowed' '
> - test_must_fail $RUN create-symref FOO refs/heads/master nothing
> + test_must_fail ok=sigabrt \
> + $RUN create-symref FOO refs/heads/master nothing
> '
>
> test_expect_success 'delete_refs() not allowed' '
> - test_must_fail $RUN delete-refs 0 nothing FOO refs/tags/new-tag
> + test_must_fail ok=sigabrt \
> + $RUN delete-refs 0 nothing FOO refs/tags/new-tag
> '
>
> test_expect_success 'rename_refs() not allowed' '
> - test_must_fail $RUN rename-ref refs/heads/master refs/heads/new-master
> + test_must_fail ok=sigabrt \
> + $RUN rename-ref refs/heads/master refs/heads/new-master
> '
>
> test_expect_success 'for_each_ref(refs/heads/)' '
> @@ -91,11 +94,11 @@ test_expect_success 'reflog_exists(HEAD)' '
> '
>
> test_expect_success 'delete_reflog() not allowed' '
> - test_must_fail $RUN delete-reflog HEAD
> + test_must_fail ok=sigabrt $RUN delete-reflog HEAD
> '
>
> test_expect_success 'create-reflog() not allowed' '
> - test_must_fail $RUN create-reflog HEAD 1
> + test_must_fail ok=sigabrt $RUN create-reflog HEAD 1
> '
I can't quite follow the rationale for this change. A 'BUG' error exit
must never be reached, otherwise it is a bug in the program by
definition. It cannot be OK that SIGABRT is a valid result from Git.
If SIGABRT occurs as a result of BUG(), and we know that this happens
for certain cases, it means we have an unfixed bug. Should then not run
these cases under test_expect_failure instead of test_expect_success to
identify them as known bugs?
Confused.
-- Hannes
next prev parent reply other threads:[~2018-04-30 19:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 22:17 [PATCH 0/6] Finish the conversion from die("BUG: ...") to BUG() Johannes Schindelin
2018-04-29 22:17 ` [PATCH 1/6] test_must_fail: support ok=sigabrt Johannes Schindelin
2018-04-29 22:17 ` [PATCH 2/6] t1406: prepare for the refs code to fail with BUG() Johannes Schindelin
2018-04-30 19:32 ` Johannes Sixt [this message]
2018-05-01 11:04 ` Johannes Schindelin
2018-05-01 11:22 ` Duy Nguyen
2018-05-01 11:26 ` Duy Nguyen
2018-05-02 3:40 ` Junio C Hamano
2018-05-02 7:41 ` Johannes Schindelin
2018-05-02 10:41 ` Junio C Hamano
2018-04-29 22:18 ` [PATCH 3/6] refs/*: report bugs using the BUG() macro Johannes Schindelin
2018-04-29 22:18 ` [PATCH 4/6] run-command: use BUG() to report bugs, not die() Johannes Schindelin
2018-04-29 22:19 ` [PATCH 5/6] Replace all die("BUG: ...") calls by BUG() ones Johannes Schindelin
2018-04-29 22:19 ` [PATCH 6/6] Convert remaining die*(BUG) messages Johannes Schindelin
2018-04-30 2:53 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7087f0b9-1362-f8ca-315d-96d27b91b26b@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).