From: Ben Peart <peartben@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Ben Peart <benpeart@microsoft.com>
Cc: git@vger.kernel.org, pclouds@gmail.com, bmwill@google.com,
avarab@gmail.com
Subject: Re: [PATCH v1] dir.c: don't flag the index as dirty for changes to the untracked cache
Date: Mon, 5 Feb 2018 20:39:43 -0500 [thread overview]
Message-ID: <6ff2ecb4-7e37-3b06-3722-cccec2329934@gmail.com> (raw)
In-Reply-To: <xmqqd11j9mx2.fsf@gitster-ct.c.googlers.com>
On 2/5/2018 3:55 PM, Junio C Hamano wrote:
> Ben Peart <benpeart@microsoft.com> writes:
>
>> The untracked cache saves its current state in the UNTR index extension.
>> Currently, _any_ change to that state causes the index to be flagged as dirty
>> and written out to disk. Unfortunately, the cost to write out the index can
>> exceed the savings gained by using the untracked cache. Since it is a cache
>> that can be updated from the current state of the working directory, there is
>> no functional requirement that the index be written out for every change to the
>> untracked cache.
>>
>> Update the untracked cache logic so that it no longer forces the index to be
>> written to disk except in the case where the extension is being turned on or
>> off. When some other git command requires the index to be written to disk, the
>> untracked cache will take advantage of that to save it's updated state as well.
>> This results in a performance win when looked at over common sequences of git
>> commands (ie such as a status followed by add, commit, etc).
>>
>> After this patch, all the logic to track statistics for the untracked cache
>> could be removed as it is only used by debug tracing used to debug the untracked
>> cache.
>>
>> Signed-off-by: Ben Peart <benpeart@microsoft.com>
>> ---
>>
>
> OK, so in other words (note: not a suggestion to use different
> wording in the log message; just making sure I got the motivation
> behind this change correctly), without this new environment
> variable, changes to untracked cache alone (due to observed changes
> in the filesystem) does not count as "in-core index changed so we
> need to write it back to the disk".
>
Correct
> That makes sense to me.
>
> Is it envisioned that we want to have similar but different "testing
> only" behaviour around this area? If not, this environment variable
> sounds more like "force-flush untracked cache", not "test untracked
> cache", to me.
>
Many of the tests make a change and then verify that the on disk
structure was updated correctly. This was the simplest way to keep
those tests functioning. I don't imagine this would be used for anything
other than enabling the tests. I hate naming so am happy to name it
which ever you think is best. :)
>> +GIT_TEST_UNTRACKED_CACHE=true
>> +export GIT_TEST_UNTRACKED_CACHE
>> +
>> sync_mtime () {
>> find . -type d -ls >/dev/null
>> }
>>
>> base-commit: 5be1f00a9a701532232f57958efab4be8c959a29
next prev parent reply other threads:[~2018-02-06 1:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 19:56 [PATCH v1] dir.c: don't flag the index as dirty for changes to the untracked cache Ben Peart
2018-02-05 20:55 ` Junio C Hamano
2018-02-06 1:39 ` Ben Peart [this message]
2018-02-05 21:58 ` Brandon Williams
2018-02-06 1:48 ` Ben Peart
2018-02-06 12:27 ` Duy Nguyen
2018-02-06 12:55 ` Duy Nguyen
2018-02-07 10:59 ` Duy Nguyen
2018-02-07 13:46 ` Ben Peart
2018-02-06 14:50 ` Junio C Hamano
2018-02-07 14:13 ` Ben Peart
2018-02-12 10:20 ` Duy Nguyen
2018-02-12 17:57 ` Ben Peart
2018-02-13 9:57 ` Duy Nguyen
2018-02-08 10:33 ` Jeff King
2018-02-28 21:27 ` Junio C Hamano
2018-03-01 7:42 ` Jeff King
2018-03-01 12:35 ` Ben Peart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ff2ecb4-7e37-3b06-3722-cccec2329934@gmail.com \
--to=peartben@gmail.com \
--cc=avarab@gmail.com \
--cc=benpeart@microsoft.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).