git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH 1/2] ci(visual-studio): use strict compile flags, and optimization
Date: Sun, 20 Oct 2019 20:39:29 +0000	[thread overview]
Message-ID: <6fba3b1c76d6e28c1ef4fd6c933bd73531e6cb7e.1571603970.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.410.git.1571603970.gitgitgadget@gmail.com>

From: Johannes Schindelin <johannes.schindelin@gmx.de>

To make full use of the work that went into the Visual Studio build &
test jobs in our CI/PR builds, let's turn on strict compiler flags. This
will give us the benefit of Visual C's compiler warnings (which, at
times, seem to catch things that GCC does not catch, and vice versa).

While at it, also turn on optimization; It does not make sense to
produce binaries with debug information, and we can use any ounce of
speed that we get (because the test suite is particularly slow on
Windows, thanks to the need to run inside a Unix shell, which
requires us to use the POSIX emulation layer provided by MSYS2).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 azure-pipelines.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 9f099b9529..457c6fee31 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -157,7 +157,7 @@ jobs:
     displayName: 'Download git-sdk-64-minimal'
   - powershell: |
       & git-sdk-64-minimal\usr\bin\bash.exe -lc @"
-        make vcxproj
+        make NDEBUG=1 DEVELOPER=1 vcxproj
       "@
       if (!$?) { exit(1) }
     displayName: Generate Visual Studio Solution
-- 
gitgitgadget


  reply	other threads:[~2019-10-20 20:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20 20:39 [PATCH 0/2] Fix the speed of the CI (Visual Studio) tests Johannes Schindelin via GitGitGadget
2019-10-20 20:39 ` Johannes Schindelin via GitGitGadget [this message]
2019-10-20 20:39 ` [PATCH 2/2] ci(visual-studio): actually run the tests in parallel Johannes Schindelin via GitGitGadget
2019-10-20 21:23   ` Eric Sunshine
2019-10-21 19:59 ` [PATCH v2 0/2] Fix the speed of the CI (Visual Studio) tests Johannes Schindelin via GitGitGadget
2019-10-21 19:59   ` [PATCH v2 1/2] ci(visual-studio): use strict compile flags, and optimization Johannes Schindelin via GitGitGadget
2019-10-21 19:59   ` [PATCH v2 2/2] ci(visual-studio): actually run the tests in parallel Johannes Schindelin via GitGitGadget
2019-10-23  2:06   ` [PATCH v2 0/2] Fix the speed of the CI (Visual Studio) tests Junio C Hamano
2019-10-24 23:23     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fba3b1c76d6e28c1ef4fd6c933bd73531e6cb7e.1571603970.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).