git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: git@vger.kernel.org
Cc: "Eric Sunshine" <sunshine@sunshineco.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Martin Ågren" <martin.agren@gmail.com>,
	"Ben Toews" <mastahyeti@gmail.com>, "Jeff King" <peff@peff.net>,
	"Taylor Blau" <me@ttaylorr.com>,
	"brian m . carlson" <sandals@crustytoothpaste.net>,
	"Henning Schild" <henning.schild@siemens.com>
Subject: [PATCH v3 4/7] gpg-interface: do not hardcode the key string len anymore
Date: Fri, 13 Jul 2018 10:41:26 +0200	[thread overview]
Message-ID: <6fb618aefcf34695cd46b3135829b5ac3f703573.1531470729.git.henning.schild@siemens.com> (raw)
In-Reply-To: <cover.1531470729.git.henning.schild@siemens.com>
In-Reply-To: <cover.1531470729.git.henning.schild@siemens.com>

gnupg does print the keyid followed by a space and the signer comes
next. The same pattern is also used in gpgsm, but there the key length
would be 40 instead of 16. Instead of hardcoding the expected length,
find the first space and calculate it.
Input that does not match the expected format will be ignored now,
before we jumped to found+17 which might have been behind the end of an
unexpected string.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 gpg-interface.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gpg-interface.c b/gpg-interface.c
index 699651fd9..93bd0fb32 100644
--- a/gpg-interface.c
+++ b/gpg-interface.c
@@ -89,10 +89,11 @@ static void parse_gpg_output(struct signature_check *sigc)
 		sigc->result = sigcheck_gpg_status[i].result;
 		/* The trust messages are not followed by key/signer information */
 		if (sigc->result != 'U') {
-			sigc->key = xmemdupz(found, 16);
+			next = strchrnul(found, ' ');
+			sigc->key = xmemdupz(found, next - found);
 			/* The ERRSIG message is not followed by signer information */
-			if (sigc-> result != 'E') {
-				found += 17;
+			if (*next && sigc-> result != 'E') {
+				found = next + 1;
 				next = strchrnul(found, '\n');
 				sigc->signer = xmemdupz(found, next - found);
 			}
-- 
2.16.4


  parent reply	other threads:[~2018-07-13  8:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  8:41 [PATCH v3 0/7] X509 (gpgsm) commit signing support Henning Schild
2018-07-13  8:41 ` [PATCH v3 1/7] gpg-interface: add new config to select how to sign a commit Henning Schild
2018-07-16 20:14   ` Junio C Hamano
2018-07-16 21:38     ` Jeff King
2018-07-17 12:50     ` Henning Schild
2018-07-17  0:03   ` brian m. carlson
2018-07-17  0:55     ` Jeff King
2018-07-13  8:41 ` [PATCH v3 2/7] t/t7510: check the validation of the new config gpg.format Henning Schild
2018-07-16 20:15   ` Junio C Hamano
2018-07-13  8:41 ` [PATCH v3 3/7] gpg-interface: introduce an abstraction for multiple gpg formats Henning Schild
2018-07-16 20:40   ` Junio C Hamano
2018-07-17 12:50     ` Henning Schild
2018-07-13  8:41 ` Henning Schild [this message]
2018-07-16 20:40   ` [PATCH v3 4/7] gpg-interface: do not hardcode the key string len anymore Junio C Hamano
2018-07-13  8:41 ` [PATCH v3 5/7] gpg-interface: introduce new config to select per gpg format program Henning Schild
2018-07-16 20:45   ` Junio C Hamano
2018-07-17 12:50     ` Henning Schild
2018-07-13  8:41 ` [PATCH v3 6/7] gpg-interface: introduce new signature format "x509" using gpgsm Henning Schild
2018-07-13  8:41 ` [PATCH v3 7/7] gpg-interface t: extend the existing GPG tests with GPGSM Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fb618aefcf34695cd46b3135829b5ac3f703573.1531470729.git.henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=martin.agren@gmail.com \
    --cc=mastahyeti@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).