From: Phillip Wood <phillip.wood123@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Leah Neukirchen" <leah@vuxu.org>, "Jeff King" <peff@peff.net>,
"Junio C Hamano" <gitster@pobox.com>,
"Randall S. Becker" <rsbecker@nexbridge.com>,
"Brian M. Carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH v4] help: colorize man pages
Date: Thu, 20 May 2021 19:00:15 +0100 [thread overview]
Message-ID: <6dc0fcee-3415-e6f9-df30-c97de4385f56@gmail.com> (raw)
In-Reply-To: <60a6877fa8389_2747c20842@natae.notmuch>
On 20/05/2021 16:59, Felipe Contreras wrote:
> Phillip Wood wrote:
>> On 20/05/2021 14:58, Felipe Contreras wrote:
>>> Phillip Wood wrote:
>>>> On 20/05/2021 05:07, Felipe Contreras wrote:
>>>>> [...]
>>>>> If the user has already set the LESS variable in his/her environment,
>>>>> that is respected, and nothing changes.
>>>>
>>>> However if they have specified the colors they would like by using the
>>>> LESS_TERMCAP_xx environment variables that the previous versions of this
>>>> patch used their choice is overridden by this new patch.
>>>
>>> That is true. We could add a check for that:
>>>
>>> if (getenv("LESS_TERMCAP_md"))
>>> return;
>>>
>>> However, it may not be necessary since many of the tips online set these
>>> variables inside a function.
>>
>> The only person who has tested this patch has reported a problem with
>> it, it seems unlikely that no other users will have similar issues.
>
> The check above will fix your problem, will it not?
Yes it will if it is implemented which was not clear as your message
suggested it may not be necessary. I think it would be safer to check
LESS_TERMCAP_{md,us,so} and not set LESS if any of them are set as it is
possible a user may only override some of them.
Best Wishes
Phillip
next prev parent reply other threads:[~2021-05-20 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 4:07 [PATCH v4] help: colorize man pages Felipe Contreras
2021-05-20 9:26 ` Phillip Wood
2021-05-20 13:58 ` Felipe Contreras
2021-05-20 15:13 ` Phillip Wood
2021-05-20 15:59 ` Felipe Contreras
2021-05-20 18:00 ` Phillip Wood [this message]
2021-05-21 17:43 ` Felipe Contreras
2021-05-21 5:06 ` Junio C Hamano
2021-05-21 8:44 ` Jeff King
2021-05-21 18:01 ` Felipe Contreras
2021-05-21 20:26 ` Jeff King
2021-05-21 21:40 ` Felipe Contreras
2021-05-22 9:55 ` Jeff King
2021-05-22 12:43 ` Philip Oakley
2021-05-22 20:53 ` Felipe Contreras
2021-05-22 20:49 ` Felipe Contreras
2021-05-21 17:54 ` Felipe Contreras
2021-05-20 14:39 ` Leah Neukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc0fcee-3415-e6f9-df30-c97de4385f56@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=leah@vuxu.org \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).