From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id ABC3C20954 for ; Thu, 30 Nov 2017 09:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750903AbdK3JrZ (ORCPT ); Thu, 30 Nov 2017 04:47:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:48513 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbdK3JrY (ORCPT ); Thu, 30 Nov 2017 04:47:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 56644AAB9; Thu, 30 Nov 2017 09:47:23 +0000 (UTC) Subject: Re: imap-send with gmail: curl_easy_perform() failed: URL using bad/illegal format or missing URL From: Nicolas Morey-Chaisemartin To: Jonathan Nieder , Doron Behar Cc: git@vger.kernel.org, Nicolas Morey-Chaisemartin References: <20171129171301.l3coiflkfyy533yz@NUC.localdomain> <20171130020445.GF15098@aiede.mtv.corp.google.com> <50fb321e-bbfc-adae-992d-eea1b818171e@suse.de> Openpgp: preference=signencrypt Message-ID: <6b1b1c11-cf17-35e8-1d33-42102d9526ea@suse.de> Date: Thu, 30 Nov 2017 10:47:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Thunderbird/57.0 MIME-Version: 1.0 In-Reply-To: <50fb321e-bbfc-adae-992d-eea1b818171e@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: fr-xx-classique+reforme1990 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Le 30/11/2017 à 10:39, Nicolas Morey-Chaisemartin a écrit : > > Le 30/11/2017 à 03:04, Jonathan Nieder a écrit : >> (+cc: Nicolas) >> Hi, >> >> Doron Behar wrote: >> >>> I'm trying to send a patch with the command `git imap-send`, I used the >>> examples in the manual page as the main reference for my configuration: >>> >>> ``` >>> [imap] >>> folder = "[Gmail]/Drafts" >>> host = imaps://imap.gmail.com >>> user = doron.behar@gmail.com >>> port = 993 >>> sslverify = false >>> ``` >>> >>> This is my `cat patch.out | git imap-send` output: >>> >>> ``` >>> Password for 'imaps://doron.behar@gmail.com@imap.gmail.com': >>> sending 3 messages >>> curl_easy_perform() failed: URL using bad/illegal format or missing URL >>> ``` >> Thanks for reporting this. I suspect this is related to >> v2.15.0-rc0~63^2 (imap-send: use curl by default when possible, >> 2017-09-14) --- e.g. perhaps our custom IMAP code was doing some >> escaping on the username that libcurl does not do. >> >> "man git imap-send" says this is a recommended configuration, so I >> don't think it's a configuration error. >> >> What platform are you on? What version of libcurl are you using? >> >> In libcurl::lib/easy.c I am also seeing >> >> if(mcode) >> return CURLE_URL_MALFORMAT; /* TODO: return a proper error! */ >> >> which looks suspicious. >> >> Nicolas, am I on the right track? >> >> Thanks, >> Jonathan >> > This is due to the weird "[Gmail]" prefix in the folder. > I tried manually replacing it with: >         folder = %5BGmail%5D/Drafts > in .git/config and it works. > > curl is doing some fancy handling with brackets and braces. It make sense for multiple FTP downloads like ftp://ftp.numericals.com/file[1-100].txt, not in our case. > The curl command line has a --globoff argument to disable this "regexp" support and it seems to fix the gmail case. In fact no, StackOverflow was wrong :) > However I couldn't find a way to change this value through the API... > > I guess we should open a bug upstream to get access to this setting through the API and add a patch that HTTP encode brackets and braces in the meantime. > This means with have to URI encode the folder. DO we have a helper for that ? Nicolas