From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EDA0920248 for ; Sun, 17 Mar 2019 08:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbfCQISw (ORCPT ); Sun, 17 Mar 2019 04:18:52 -0400 Received: from bsmtp7.bon.at ([213.33.87.19]:44380 "EHLO bsmtp7.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbfCQISw (ORCPT ); Sun, 17 Mar 2019 04:18:52 -0400 Received: from dx.site (unknown [93.83.142.38]) by bsmtp7.bon.at (Postfix) with ESMTPSA id 44MXJp1dLMz5tlD; Sun, 17 Mar 2019 09:18:49 +0100 (CET) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id F2B18D5; Sun, 17 Mar 2019 09:18:48 +0100 (CET) Subject: Re: "man gitattributes" doesn't explain comma-separated attribute values To: "Robert P. J. Day" Cc: Git Mailing list References: <408d82f6-e935-487a-6d0c-9ec4be5e8b6e@kdbg.org> From: Johannes Sixt Message-ID: <6aeca231-c024-1063-0f8c-03276c83161c@kdbg.org> Date: Sun, 17 Mar 2019 09:18:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 16.03.19 um 23:09 schrieb Robert P. J. Day: > On Sat, 16 Mar 2019, Johannes Sixt wrote: > >> Am 16.03.19 um 13:22 schrieb Robert P. J. Day: >>> as a working example, i looked at the top-level .gitattributes file >>> in the git source code itself, which opens with: >>> >>> * whitespace=!indent,trail,space >>> *.[ch] whitespace=indent,trail,space diff=cpp >>> *.sh whitespace=indent,trail,space eol=lf >>> ... snip ... >>> >>> first observation is that i see nothing in the man page that explains >>> the notion of a comma-separated list of attribute values. >> >> This comma-separated list is not a property of attributes in >> general, but a property of the whitespace attribute in particular. >> See core.whitespace in git-config(1) and "Checking whitespace >> errors" in gitattributes(5). > > ah, i was digging through the code trying to figure out where the > whole CSV thing was explained -- it's massively helpful to understand > that that property is specific to whitespace. that does not appear to > be clarified anywhere. But it is. The very first paragraph of gitattributes(5) states that attributes are whitespace separated. From this, conclude that the comma-separated list must pertain to the whitespace attribute. Now follow the documentation of that, and you end up at core.whitespace in git-config(1). There you have it as the very first phrase. -- Hannes