From: Yann Droneaud <ydroneaud@opteya.com>
To: <git@vger.kernel.org>
Subject: git diff returns fatal error with core.safecrlf is set to true.
Date: Fri, 21 Jun 2013 15:26:51 +0200 [thread overview]
Message-ID: <6a3d8a2b19a859d8c969ee434e1d6a89@meuh.org> (raw)
Hi,
Following my previous email "Tracking vendor release with Git" [1][2],
and the advice from Git users/developers, I'm trying to use
.gitattributes
to handle CRLF/LF conversion.
While testing the behavor of Git regarding CRLF handling,
when core.safecrlf is set to true, I've found that "git diff" is
returning
"fatal: CRLF would be replaced by LF" without returning any kind of
diff.
This make me wonder if its the correct behavor for git diff to (only)
fail:
It should be fatal for git add / git commit ( / git cherry-pick / ...
?),
but non fatal for git diff.
According to the documentation git-config(5) [3]:
"Git will verify if a command modifies a file in the work tree either
directly or indirectly"
I don't thing "git diff" is an operation that could modify a file.
Regards.
1. <1370970410-7935-1-git-send-email-ydroneaud@opteya.com>
2. <http://thread.gmane.org/gmane.comp.version-control.git/227466>
<http://marc.info/?l=git&m=137097069115462&w=2>
3. https://www.kernel.org/pub/software/scm/git/docs/git-config.html
--
Yann Droneaud
OPTEYA
next reply other threads:[~2013-06-21 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 13:26 Yann Droneaud [this message]
2013-06-21 15:44 ` git diff returns fatal error with core.safecrlf is set to true Junio C Hamano
2013-06-21 21:57 ` Junio C Hamano
2013-06-24 12:42 ` Yann Droneaud
2013-06-24 18:19 ` Junio C Hamano
2013-06-24 21:48 ` Junio C Hamano
2013-06-25 20:29 ` Torsten Bögershausen
2013-06-26 15:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a3d8a2b19a859d8c969ee434e1d6a89@meuh.org \
--to=ydroneaud@opteya.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).