git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>, git@vger.kernel.org
Cc: christian.couder@gmail.com, gitster@pobox.com,
	Johannes.Schindelin@gmx.de, heba.waly@gmail.com,
	stolee@gmail.com, jnareb@gmail.com
Subject: Re: [GSoC] Shourya's Blog
Date: Thu, 28 May 2020 18:45:31 +0530	[thread overview]
Message-ID: <6A4BE88D-40E8-4481-9959-891B26B05BAA@gmail.com> (raw)
In-Reply-To: <20200527162048.GA19421@konoha>

Hi Shourya,


On 27 May 2020 21:50:48 GMT+05:30, Shourya Shukla <shouryashukla.oo@gmail.com> wrote:
>Hello,
>
>This is the third installation of my GSoC blog covering week 3
>https://shouryashukla.blogspot.com/2020/05/gsoc-week-3.html
>
>All feedbacks and suggestions are welcome! :)

I'll mention a couple of things that came to me after re-reading the blog. The blog reads:

> And the final one, comments should be not confusing. to solve the 1st issue in v3, I put up a comment which was:
>
>    The `quiet` option is present for backward compatibility but is currently not used.
>
> Do I even need to explain how ambiguous this is (something which took me one whole patch to realise)?

While you don't have to explain the ambiguity for someone who has read the review discussion, it is possible that someone who has not read Junio's e-mail[1] might not understand what ambiguity is present in that comment. So, it would've been nice if you had explained the ambiguity.

Another thing, you thank Junio for the updated comment (which is nice). But it's not clear from the blog how Junio contributed to that comment. This could've been avoided by adding more information about the context which in this case is (again) Junio's e-mail about the ambiguous comment.

Things to keep in mind for future blogs :)

---
Footnotes:

[1]: https://public-inbox.org/git/xmqqk115ruux.fsf@gitster.c.googlers.com/

-- 
Sivaraam

Sent from my Android device with K-9 Mail. Please excuse my brevity and possible "typso".

  reply	other threads:[~2020-05-28 13:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 16:20 Shourya Shukla
2020-05-28 13:15 ` Kaartic Sivaraam [this message]
2020-06-16  7:21 Shourya Shukla
2020-06-17  8:38 ` Kaartic Sivaraam
2020-06-20  6:55   ` Shourya Shukla
2020-06-17 20:35 ` Junio C Hamano
2020-06-23 18:14 Shourya Shukla
2020-06-28  9:39 Shourya Shukla
2020-07-05 18:38 Shourya Shukla
2020-07-14 22:10 Shourya Shukla
2020-07-28 10:11 Shourya Shukla
2020-08-05 17:46 Shourya Shukla
2020-08-14  7:14 ` Christian Couder
2020-08-24  7:50 Shourya Shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6A4BE88D-40E8-4481-9959-891B26B05BAA@gmail.com \
    --to=kaartic.sivaraam@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=heba.waly@gmail.com \
    --cc=jnareb@gmail.com \
    --cc=shouryashukla.oo@gmail.com \
    --cc=stolee@gmail.com \
    --subject='Re: [GSoC] Shourya'\''s Blog' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).