From: Joshua Juran <jjuran@gmail.com>
To: Bruce Stephens <bruce.stephens@isode.com>
Cc: git@vger.kernel.org
Subject: Re: Purpose of "struct object_entry *oe = oe;"?
Date: Thu, 1 Jul 2010 18:43:47 -0700 [thread overview]
Message-ID: <69D6E995-8F0E-446C-90CD-758C160A7807@gmail.com> (raw)
In-Reply-To: <8039w681lo.fsf@tiny.isode.net>
On Jun 29, 2010, at 5:28 AM, Bruce Stephens wrote:
> Out of curiousity, where did this convention/idiom come from, and
> what's
> it for?
>
> I presume it's to remove a warning ("oe might be used
> uninitialised") on
> a compiler (or something) that's clever enough to attempt such
> analysis
> but too stupid to notice that the supposed initialisation is using
> something uninitialised (or perhaps the compiler's deliberately
> recognising the convention?). Is that right, or does it actually do
> something more?
>
> I'm mostly surprised that it surprises me. Is it used commonly in
> other
> projects? (It appears not to be mentioned in CodingGuidelines; should
> it be?)
I was wondering this myself. My compiler complains in (and only in)
the *presence* of this idiom, rather than its absence, so I undid it:
jj/warn/uninitialized branch on GitHub
http://github.com/jjuran/git/tree/jj/warn/uninitialized
jj/warn/uninitialized commit on GitHub
http://github.com/jjuran/git/commit/
8affbf2d8e46fbd5f3d6898aa07ea8548432e7bc
Signed-Off-By: Joshua Juran <jjuran@gmail.com> (or s/gmail/metamage/)
A compiler that warns of uninitialized usage *unless* a variable is
initialized *with itself* is doubly broken.
Cheers,
Josh
next prev parent reply other threads:[~2010-07-02 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 12:28 Purpose of "struct object_entry *oe = oe;"? Bruce Stephens
2010-07-02 1:43 ` Joshua Juran [this message]
2010-07-02 8:48 ` David Aguilar
2010-07-02 9:28 ` Bruce Stephens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69D6E995-8F0E-446C-90CD-758C160A7807@gmail.com \
--to=jjuran@gmail.com \
--cc=bruce.stephens@isode.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).