git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* Pre-commit hook does not work properly in recent version
@ 2018-12-13 15:03 Andrew Kharchenko
  2018-12-13 19:19 ` Johannes Schindelin
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Kharchenko @ 2018-12-13 15:03 UTC (permalink / raw)
  To: git

Hello,

I found a bug in Git v. 2.20.0 and 2.19.x at least, where pre-commit hook does not work properly.

OS: macOS High Sierra
Git: 2.20.0, 2.19.x

Description: pre-commit file should be marked as executable in order to recreate the bug. When executing “git commit”, it silently exits without any message.
It was found, that Git version 2.17.1 still works as expected.

—
Sincerely, 
Andrew Kharchenko

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Pre-commit hook does not work properly in recent version
  2018-12-13 15:03 Pre-commit hook does not work properly in recent version Andrew Kharchenko
@ 2018-12-13 19:19 ` Johannes Schindelin
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2018-12-13 19:19 UTC (permalink / raw)
  To: Andrew Kharchenko; +Cc: git

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi Andrew,

On Thu, 13 Dec 2018, Andrew Kharchenko wrote:

> I found a bug in Git v. 2.20.0 and 2.19.x at least, where pre-commit hook does not work properly.
> 
> OS: macOS High Sierra
> Git: 2.20.0, 2.19.x
> 
> Description: pre-commit file should be marked as executable in order to recreate the bug. When executing “git commit”, it silently exits without any message.
> It was found, that Git version 2.17.1 still works as expected.

Have you dug deeper? Like, add a `set -x` at the beginning of that hook to
find out why it is exiting early?

Ciao,
Johannes

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-13 19:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 15:03 Pre-commit hook does not work properly in recent version Andrew Kharchenko
2018-12-13 19:19 ` Johannes Schindelin

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git