git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API
@ 2017-01-12 10:42 eroen
  2017-01-12 16:53 ` Jack Bates
  2017-01-12 16:55 ` Jack Bates
  0 siblings, 2 replies; 3+ messages in thread
From: eroen @ 2017-01-12 10:42 UTC (permalink / raw)
  To: git; +Cc: eroen

Library initialization functions are deprecated in openssl 1.1.0 API, as
initialization is handled by openssl internally.

Symbols for deprecated functions are not exported if openssl is built with
`--api=1.1 disable-deprecated`, so their use will cause a build failure.

Reported-by: Lars Wendler (Polynomial-C)

X-Gentoo-Bug: 592466
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466
---
 imap-send.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/imap-send.c b/imap-send.c
index 5c7e27a89..98774360e 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
 	int ret;
 	X509 *cert;
 
+#if OPENSSL_VERSION_NUMBER < 0x10100000L
 	SSL_library_init();
 	SSL_load_error_strings();
+#endif
 
 	meth = SSLv23_method();
 	if (!meth) {
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API
  2017-01-12 10:42 [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API eroen
@ 2017-01-12 16:53 ` Jack Bates
  2017-01-12 16:55 ` Jack Bates
  1 sibling, 0 replies; 3+ messages in thread
From: Jack Bates @ 2017-01-12 16:53 UTC (permalink / raw)
  To: git

You might need the following, to still build with LibreSSL.
That was my experience anyway, when I recently prepared similar fixes 
for OpenSSL 1.1 and Apache Traffic Server.

#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)

On 12/01/17 03:42 AM, eroen wrote:
> Library initialization functions are deprecated in openssl 1.1.0 API, as
> initialization is handled by openssl internally.
>
> Symbols for deprecated functions are not exported if openssl is built with
> `--api=1.1 disable-deprecated`, so their use will cause a build failure.
>
> Reported-by: Lars Wendler (Polynomial-C)
>
> X-Gentoo-Bug: 592466
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466
> ---
>  imap-send.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/imap-send.c b/imap-send.c
> index 5c7e27a89..98774360e 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
>  	int ret;
>  	X509 *cert;
>
> +#if OPENSSL_VERSION_NUMBER < 0x10100000L
>  	SSL_library_init();
>  	SSL_load_error_strings();
> +#endif
>
>  	meth = SSLv23_method();
>  	if (!meth) {
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API
  2017-01-12 10:42 [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API eroen
  2017-01-12 16:53 ` Jack Bates
@ 2017-01-12 16:55 ` Jack Bates
  1 sibling, 0 replies; 3+ messages in thread
From: Jack Bates @ 2017-01-12 16:55 UTC (permalink / raw)
  To: eroen, git

You might need the following, to still build with LibreSSL.
That was my experience anyway, when I recently prepared similar fixes 
for OpenSSL 1.1 and Apache Traffic Server.

#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)

On 12/01/17 03:42 AM, eroen wrote:
> Library initialization functions are deprecated in openssl 1.1.0 API, as
> initialization is handled by openssl internally.
>
> Symbols for deprecated functions are not exported if openssl is built with
> `--api=1.1 disable-deprecated`, so their use will cause a build failure.
>
> Reported-by: Lars Wendler (Polynomial-C)
>
> X-Gentoo-Bug: 592466
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466
> ---
>  imap-send.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/imap-send.c b/imap-send.c
> index 5c7e27a89..98774360e 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
>  	int ret;
>  	X509 *cert;
>
> +#if OPENSSL_VERSION_NUMBER < 0x10100000L
>  	SSL_library_init();
>  	SSL_load_error_strings();
> +#endif
>
>  	meth = SSLv23_method();
>  	if (!meth) {
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-12 16:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-12 10:42 [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API eroen
2017-01-12 16:53 ` Jack Bates
2017-01-12 16:55 ` Jack Bates

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).