git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff Hostetler <git@jeffhostetler.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Jeff Hostetler <jeffhost@microsoft.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] list-objects-filter-options: fix up some sparse warnings
Date: Tue, 21 Nov 2017 07:36:04 -0500	[thread overview]
Message-ID: <654367f1-bc59-d546-a37d-dcb8f13ca65e@jeffhostetler.com> (raw)
In-Reply-To: <b1037774-6ae6-630b-f330-e95b1c3d681d@ramsayjones.plus.com>



On 11/20/2017 6:39 PM, Ramsay Jones wrote:
> 
> In particular, sparse complains that the armor_{en,de}code_arg()
> functions are 'not declared - should they be static?'. Since the
> armor_decode_arg() symbol does not require more than file visibility,
> we can simply mark the declaration with static. The armor_encode_arg()
> function has no callers, so we simply remove the (unused) definition.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Jeff,
> 
> If you need to re-roll your 'jh/object-filtering' branch, could you
> please squash this (or something like it) into the relevant patch
> (commit bf0aedcbe1, "list-objects: filter objects in traverse_commit_list",
> 16-11-2017).
> 

thanks for the note.
i'm going to remove these functions completely in my next version.
it was decided that we don't need to do encoding/decoding at this level.

Thanks,
Jeff


      parent reply	other threads:[~2017-11-21 12:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 23:39 [PATCH] list-objects-filter-options: fix up some sparse warnings Ramsay Jones
2017-11-21  1:16 ` Jonathan Nieder
2017-11-21 11:04   ` Ramsay Jones
2017-11-22  0:23     ` Stefan Beller
2017-11-21 12:36 ` Jeff Hostetler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=654367f1-bc59-d546-a37d-dcb8f13ca65e@jeffhostetler.com \
    --to=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).