From: Marc Branchaud <marcnarc@xiplink.com>
To: Bert Wesarg <bert.wesarg@googlemail.com>, git@vger.kernel.org
Cc: paulus@ozlabs.org
Subject: Re: [PATCH] gitk: Add horizontal scrollbar to the files list
Date: Tue, 1 Oct 2019 11:42:01 -0400 [thread overview]
Message-ID: <650bb0ab-50e8-96a6-957a-ebf3e75efed2@xiplink.com> (raw)
In-Reply-To: <5c5803ac99b6aaf7ca39393422ca9aa17f0280ec.1569910203.git.bert.wesarg@googlemail.com>
On 2019-10-01 6:08 a.m., Bert Wesarg wrote:
> Wrapping filenames is an unexpected experience in UX design. Disable
> wrapping and add a horizontal scrollbar to the files list to remove this.
(Thanks for working on gitk and git-gui!)
I have to say I'm mildly opposed to this change. The reason is that
having to scroll to see the end of the filename is extra work, and it's
work that would have to be repeated as one navigates between commits in
the same area of code. Git-gui has scrollbars for its filename panes,
and I find them more of a hassle that gitk's wrapping. (The horizontal
scrollbar might work better if it defaulted to scrolling all the way to
the *right* instead of to the left.)
But I would instead prefer there to be some visual indication that the
filename was wrapped. Maybe indent the wrapped lines? Or how about
contracting the file path with an ellipsis (...), like "git diff --stat"?
M.
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
> ---
> gitk | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gitk b/gitk
> index abe4805..bf2a061 100755
> --- a/gitk
> +++ b/gitk
> @@ -2477,13 +2477,16 @@ proc makewindow {} {
> -background $bgcolor -foreground $fgcolor \
> -font mainfont \
> -tabs [list $indent [expr {2 * $indent}]] \
> - -yscrollcommand ".bright.sb set" \
> + -xscrollcommand ".bright.sbx set" \
> + -yscrollcommand ".bright.sby set" \
> -cursor [. cget -cursor] \
> - -spacing1 1 -spacing3 1
> + -spacing1 1 -spacing3 1 -wrap none
> lappend bglist $cflist
> lappend fglist $cflist
> - ${NS}::scrollbar .bright.sb -command "$cflist yview"
> - pack .bright.sb -side right -fill y
> + ${NS}::scrollbar .bright.sbx -orient horizontal -command "$cflist xview"
> + ${NS}::scrollbar .bright.sby -orient vertical -command "$cflist yview"
> + pack .bright.sbx -side bottom -fill x
> + pack .bright.sby -side right -fill y
> pack $cflist -side left -fill both -expand 1
> $cflist tag configure highlight \
> -background [$cflist cget -selectbackground]
>
prev parent reply other threads:[~2019-10-01 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 10:08 [PATCH] gitk: Add horizontal scrollbar to the files list Bert Wesarg
2019-10-01 15:42 ` Marc Branchaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=650bb0ab-50e8-96a6-957a-ebf3e75efed2@xiplink.com \
--to=marcnarc@xiplink.com \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).