From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] commit: don't check for space twice when looking for header
Date: Sat, 25 Feb 2017 22:39:29 +0100 [thread overview]
Message-ID: <6462e74c-1ee7-7ed0-0695-9889df803943@web.de> (raw)
In-Reply-To: <20170225201522.uan52fwey6zjosym@sigill.intra.peff.net>
Am 25.02.2017 um 21:15 schrieb Jeff King:
> On Sat, Feb 25, 2017 at 08:27:40PM +0100, René Scharfe wrote:
>
>> Both standard_header_field() and excluded_header_field() check if
>> there's a space after the buffer that's handed to them. We already
>> check in the caller if that space is present. Don't bother calling
>> the functions if it's missing, as they are guaranteed to return 0 in
>> that case, and remove the now redundant checks from them.
>
> Makes sense, and I couldn't spot any errors in your logic or in the
> code.
Thanks for checking!
>> static inline int standard_header_field(const char *field, size_t len)
>> {
>> - return ((len == 4 && !memcmp(field, "tree ", 5)) ||
>> - (len == 6 && !memcmp(field, "parent ", 7)) ||
>> - (len == 6 && !memcmp(field, "author ", 7)) ||
>> - (len == 9 && !memcmp(field, "committer ", 10)) ||
>> - (len == 8 && !memcmp(field, "encoding ", 9)));
>> + return ((len == 4 && !memcmp(field, "tree", 4)) ||
>> + (len == 6 && !memcmp(field, "parent", 6)) ||
>> + (len == 6 && !memcmp(field, "author", 6)) ||
>> + (len == 9 && !memcmp(field, "committer", 9)) ||
>> + (len == 8 && !memcmp(field, "encoding", 8)));
>
> Unrelated, but this could probably be spelled with a macro and strlen()
> to avoid the magic numbers. It would probably be measurably slower for a
> compiler which doesn't pre-compute strlen() on a string literal, though.
sizeof(string_constant) - 1 might be a better choice here than strlen().
René
next prev parent reply other threads:[~2017-02-25 21:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 19:21 [PATCH 1/2] commit: be more precise when searching for headers René Scharfe
2017-02-25 19:27 ` [PATCH 2/2] commit: don't check for space twice when looking for header René Scharfe
2017-02-25 20:15 ` Jeff King
2017-02-25 21:39 ` René Scharfe [this message]
2017-02-25 21:51 ` Jeff King
2017-02-27 22:27 ` Jakub Narębski
2017-02-27 22:54 ` René Scharfe
2017-02-25 20:12 ` [PATCH 1/2] commit: be more precise when searching for headers Jeff King
2017-02-27 19:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6462e74c-1ee7-7ed0-0695-9889df803943@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).