From: Jonathan Tan <jonathantanmy@google.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] http: attempt updating base URL only if no error
Date: Tue, 28 Feb 2017 10:48:52 -0800 [thread overview]
Message-ID: <6127c0a7-800d-fcf3-c6e2-17533347f07e@google.com> (raw)
In-Reply-To: <20170228132814.wp3cq4ilp7syinqy@sigill.intra.peff.net>
On 02/28/2017 05:28 AM, Jeff King wrote:
> Right, your patch makes sense. A real HTTP error should take precedence
> over the url-update trickery.
>
> Acked-by: Jeff King <peff@peff.net>
Thanks!
> Running your included test, we get:
>
> fatal: unable to access 'http://127.0.0.1:5550/redir-to/502/': The
> requested URL returned error: 502
>
> but the error really happened in the intermediate step. I wonder if we
> should show the effective_url in that case, as it's more likely to
> pinpoint the problem. OTOH, we do not mention the intermediate redirect
> at all, so they might be confused about where that URL came from. If you
> really want to debug HTTP confusion, you should use GIT_TRACE_CURL.
Yeah, if we mention the effective_url, I think that there would need to
be a lot more explaining to be done (e.g. why does my URL have
"info/refs?service=git-upload-pack" tacked on at the end). It might be
better to just recommend GIT_TRACE_CURL.
next prev parent reply other threads:[~2017-02-28 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 2:53 [PATCH] http: attempt updating base URL only if no error Jonathan Tan
2017-02-28 13:28 ` Jeff King
2017-02-28 18:48 ` Jonathan Tan [this message]
2017-02-28 19:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6127c0a7-800d-fcf3-c6e2-17533347f07e@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).