git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 5/5] config: add default aliases
Date: Tue, 06 Jul 2021 16:54:19 -0500	[thread overview]
Message-ID: <60e4d10bd8127_1c428120848@natae.notmuch> (raw)
In-Reply-To: <YOBA6s7wXUVmh++d@coredump.intra.peff.net>

Jeff King wrote:
> On Fri, Jul 02, 2021 at 05:05:06AM -0500, Felipe Contreras wrote:
> 
> > These are all the aliases everyone agrees are essential.
> > 
> > Virtually all VCS in the world have aliases, except git, so let's change
> > that.
> 
> For anyone reviewing or discussing, here's an older thread on the same
> topic:
> 
>   https://lore.kernel.org/git/1379791221-29925-1-git-send-email-felipe.contreras@gmail.com/
> 
> (I don't mean to imply that we can't revisit old decisions; but some of
> the thoughts there are worth considering as input).

Re-reading that thread--and filtering all the noise--the two thoughts
that I think are worth considering are:

 1. A default alias might leak into some unofficial documentation, and
    people with a different alias could be surprised after typing that
    command and finding out it does a different thing.

 2. A person might be used to an alias doing one thing, move to a
    different machine, and be surprised that the default alias does a
    diffrent thing.

But as mentioned in that thread those two are *existing* issues. People
using certain configurations (not even aliases) are surprised when the
same command does a different thing. And also people use their aliases
in unofficial documentation already.

Default aliases would in fact make the situation less worse because if
one of these aliases leaks into unofficial documentation, there's a
higher chance that the command will do what was intended.

The counter-arguments were not addressed, so the conclussion is that
default aliases would *not* make the existing problems worse.


That being said, there's ways to mitigate these problems, for example we
could add an avdice stating that a default alias is currently being
used, something like:

  hint: You are using a default alias: co -> checkout.
  hint:
  hint: If you want to incorporate this alias into your personal
  hint: aliases, type:
  hint:
  hint:  git config --global alias.co checkout
  hint:
  hint: Disable this message with "git config advice.defaultaliases false"

There's many other ways to mitigate the issues. It would be in the best
inerest of the probject to explore all these possibilities to their full
extent instead of just throwing the towel and stay in the current
undesirable state.

Cheers.

-- 
Felipe Contreras

      reply	other threads:[~2021-07-06 21:54 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 10:05 [PATCH 0/5] Default aliases Felipe Contreras
2021-07-02 10:05 ` [PATCH 1/5] test: add missing whitespaces Felipe Contreras
2021-07-02 10:05 ` [PATCH 2/5] config: trivial style fix Felipe Contreras
2021-07-02 10:05 ` [PATCH 3/5] config: trivial struct initialization cleanup Felipe Contreras
2021-07-02 10:05 ` [PATCH 4/5] config: initialize origin_type correctly Felipe Contreras
2021-07-02 10:05 ` [PATCH 5/5] config: add default aliases Felipe Contreras
2021-07-02 10:10   ` Andreas Schwab
2021-07-02 10:17     ` Felipe Contreras
2021-07-02 10:31       ` Andreas Schwab
2021-07-02 10:46         ` Felipe Contreras
2021-07-02 10:54           ` Andreas Schwab
2021-07-02 10:44       ` martin
2021-07-02 10:54         ` Felipe Contreras
2021-07-02 11:15           ` martin
2021-07-02 13:26             ` Randall S. Becker
2021-07-02 13:41               ` Ævar Arnfjörð Bjarmason
2021-07-02 14:15                 ` Randall S. Becker
2021-07-02 14:43                   ` martin
2021-07-02 20:44                     ` Felipe Contreras
2021-07-02 22:03                     ` Randall S. Becker
2021-07-02 22:32                       ` Felipe Contreras
2021-07-02 15:39               ` Junio C Hamano
2021-07-02 20:41                 ` Felipe Contreras
2021-07-02 21:02               ` Felipe Contreras
2021-07-02 21:40                 ` martin
2021-07-02 22:16                   ` Felipe Contreras
2021-07-02 22:00                 ` Randall S. Becker
2021-07-02 22:31                   ` Felipe Contreras
2021-07-02 21:12             ` Felipe Contreras
2021-07-02 21:31               ` martin
2021-07-02 22:14                 ` Felipe Contreras
2021-07-02 11:32   ` Ævar Arnfjörð Bjarmason
2021-07-02 21:58     ` Felipe Contreras
2021-07-02 22:38       ` martin
2021-07-02 23:48         ` Felipe Contreras
2021-07-05 14:02         ` Randall S. Becker
2021-07-06 15:27           ` Randall S. Becker
2021-07-06 21:59           ` Felipe Contreras
2021-07-10 15:30           ` Philip Oakley
2021-07-03 10:50   ` Jeff King
2021-07-06 21:54     ` Felipe Contreras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60e4d10bd8127_1c428120848@natae.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).