From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id BC5561F5AE for ; Tue, 15 Jun 2021 18:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbhFOSL6 (ORCPT ); Tue, 15 Jun 2021 14:11:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbhFOSL5 (ORCPT ); Tue, 15 Jun 2021 14:11:57 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED4BEC061574 for ; Tue, 15 Jun 2021 11:09:52 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id t40so19158395oiw.8 for ; Tue, 15 Jun 2021 11:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=ouKeLTrytQEx1hzSUCOGB5wJYpjHB+Sh44WKS4R6cEs=; b=fPejEm5nvU30JgOHORsvikoLZ2aUmA55Wv2OFI1v3jN6/UDlzXgX8ZJ3+NS7aNt2za 5lFsUDYBbJ2qcWHxPVC8ISuRcj8iItUwm9Ovpsu8fqvME8AzWeutXHKRRb+LFE3zHHr4 FWfRfFVv+hriZpEuKqggNMzS/j8F8Y0OmQk7c7sLifcRVmQ+mtLU8ftk1cIkfmcAnGfC vcY6eI50XtuArAGPuU6ffxC7EQ1XjKBCsS52BiXq1hLO7lbR8P+tWvaw8Gd8Z0ojtVhv +BVAEmSbwWYrTLnLSMtORWSFXc5ReVfEPdr31d0kAIsPaSl2qDeBR5KXFtf0cWnh9Wan kPHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=ouKeLTrytQEx1hzSUCOGB5wJYpjHB+Sh44WKS4R6cEs=; b=LIX7GqfAtKzJ0QY+K6IJwYuWwjYMMh6Q5H8qa8EAkD2PBJugFxmDz4T3rXkztC6j4+ bZL2MLveSZ/D/kh0CYkemDj7G5Kt5LZ1BNII0Dyy9Ca8i+jFxqXPIgHJH6xXsBWHVTAG MCnzVocViyGC8Ezvqg7sIpbUCk5lNpOsebGY7F16KJ0G+mz4VAUytR067M/Q46mteARv TXfKRuTmoI7CbxRSUmK7PONDB49mT5IaAgWzVRWs/GaXW7KtLVnqU0duhPL4so0+3OTq MrL0TfeOkSs4Dv2WZlJ+w46hL/O/4tG7yK+kkmWITIZp0nqvYG1NhizFQW+Yodii0Qa3 Kwbw== X-Gm-Message-State: AOAM531bOHvlNCtI7u7nVr8xAud+e5gRJsSKU3+6kklgI8kxbgTlOYv0 v4vimB0sj0yS8m+fmIXy8RM= X-Google-Smtp-Source: ABdhPJyiMuXq82uKpsVDRis4hjVVCoS3YpEtMz+I2/eqiNXyjkSdi3HtX4Ih2cDiuTUOs83sppa1GA== X-Received: by 2002:a05:6808:14c8:: with SMTP id f8mr280670oiw.7.1623780592396; Tue, 15 Jun 2021 11:09:52 -0700 (PDT) Received: from localhost (fixed-187-188-155-231.totalplay.net. [187.188.155.231]) by smtp.gmail.com with ESMTPSA id p25sm3971415ood.4.2021.06.15.11.09.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 11:09:51 -0700 (PDT) Date: Tue, 15 Jun 2021 13:09:50 -0500 From: Felipe Contreras To: Jeff King , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Felipe Contreras , git@vger.kernel.org, Junio C Hamano , =?UTF-8?B?Q2FybG8gTWFyY2VsbyBBcmVuYXMgQmVsw7Nu?= , John Keeping , Johannes Schindelin Message-ID: <60c8eceeae8e8_12c2820895@natae.notmuch> In-Reply-To: References: <20210609170520.67014-1-felipe.contreras@gmail.com> <60c627cac29b3_41f45208a7@natae.notmuch> <60c715dd9939e_436208f3@natae.notmuch> <8735tk22if.fsf@evledraar.gmail.com> <87r1h4z8k0.fsf@evledraar.gmail.com> Subject: Re: [PATCH] test: fix for TEST_OUTPUT_DIRECTORY Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King wrote: > On Mon, Jun 14, 2021 at 06:55:03PM +0200, =C3=86var Arnfj=C3=B6r=C3=B0 = Bjarmason wrote: > > > mkdir: cannot create directory =E2=80=98/dev/null=E2=80=99: Not a= directory > > > > > > or similar. > > = > > Yeah that error sucks, but nobody will see it unless they're hacking = on > > the guts of this $TEST_NO_RESULTS_OUTPUT, and I think it beats being = fragile. > = > I think that's a good point. You're unlikely to stumble into > accidentally using TEST_NO_RESULTS_OUTPUT, so it might not be worth > caring about too much. But check_sub_test_lib_test() cares: test_must_be_empty err = 'err' is not empty, it contains: mkdir: cannot create directory '/dev/null': File exists /home/felipec/dev/git.git/git/t/test-lib.sh: line 1133: /dev/null.count= s: Permission denied not ok 5 - pretend we have a fully passing test suite -- = Felipe Contreras=