From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nikhil Gupta" <nikhilgupta2102@gmail.com>
Cc: git-packagers@googlegroups.com, Git List <git@vger.kernel.org>
Subject: Re: Build errors when building git on MacOS 11 (x86-64) and for M1 macs
Date: Thu, 10 Jun 2021 09:24:03 -0500 [thread overview]
Message-ID: <60c22083b4131_b25b1208f6@natae.notmuch> (raw)
In-Reply-To: <87sg1p24zc.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> This is arguably a bug in git's Makefile in that we should have that
> "-I." in an ESSENTIAL_CFLAGS variable or something, I can't think of a
> scenario where git would compile without it.
If they are so essential we probably don't even need a variable, just
put it directly into the $(CC) command.
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-10 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f5487adb-b7dc-4f97-bca1-749701337759n@googlegroups.com>
2021-06-10 13:52 ` Build errors when building git on MacOS 11 (x86-64) and for M1 macs Ævar Arnfjörð Bjarmason
2021-06-10 14:24 ` Felipe Contreras [this message]
2021-06-10 14:36 ` Jeff King
2021-06-10 14:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60c22083b4131_b25b1208f6@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=nikhilgupta2102@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).