From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: RE: [PATCH] doc: explain the use of color.pager
Date: Wed, 19 May 2021 05:41:49 -0500 [thread overview]
Message-ID: <60a4eb6d58c05_86a8208af@natae.notmuch> (raw)
In-Reply-To: <YKTXlTjwOUi4W+R8@coredump.intra.peff.net>
Jeff King wrote:
> diff --git a/Documentation/config/color.txt b/Documentation/config/color.txt
> index d5daacb13a..e05d520a86 100644
> --- a/Documentation/config/color.txt
> +++ b/Documentation/config/color.txt
> @@ -127,8 +127,9 @@ color.interactive.<slot>::
> interactive commands.
>
> color.pager::
> - A boolean to enable/disable colored output when the pager is in
> - use (default is true).
> + A boolean to specify whether `auto` color modes should colorize
> + output going to the pager. Defaults to true; set this to false
> + if your pager does not understand ANSI color codes.
This sounds correct to me, short, and complete. I like it.
Acked-by: Felipe Contreras <felipe.contreras@gmail.com>
--
Felipe Contreras
next prev parent reply other threads:[~2021-05-19 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 9:17 [PATCH] doc: explain the use of color.pager Jeff King
2021-05-19 10:41 ` Felipe Contreras [this message]
2021-05-19 19:53 ` Jonathan Nieder
2021-05-19 20:39 ` Felipe Contreras
2021-05-19 22:47 ` Junio C Hamano
2021-05-20 6:36 ` Junio C Hamano
2021-05-20 8:33 ` Jeff King
2021-05-20 15:05 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a4eb6d58c05_86a8208af@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).