From: Felipe Contreras <firstname.lastname@example.org>
To: Jeff King <email@example.com>, Felipe Contreras <firstname.lastname@example.org>
Cc: email@example.com, "Junio C Hamano" <firstname.lastname@example.org>,
"brian m . carlson" <email@example.com>,
"Martin Ågren" <firstname.lastname@example.org>,
"Ævar Arnfjörð Bjarmason" <email@example.com>
Subject: Re: [PATCH v2 3/5] doc: remove unnecessary rm instances
Date: Mon, 17 May 2021 05:42:31 -0500 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
Jeff King wrote:
> On Sat, May 15, 2021 at 07:04:05AM -0500, Felipe Contreras wrote:
> > Jeff King wrote:
> > > That does differ in that it removes $@+, too, but the premise is the
> > > same (we know that $@+ could not be a problem, as we're about to
> > > clobber it anyway).
> > >
> > > I'm OK with getting rid of all of them, but it seems like it ought to be
> > > happening all in this patch.
> > Yeah, but the rationale is different.
> > 1. $(RM) $@: these remove the target file because of permissions
> > (i.e. root owned)
> > 2. $(RM) $@+ $@ && $(CODE) && mv $@+ $@: these are for interrupted builds
> > To get rid of #2 we need an alternative solution, like .DELETE_ON_ERROR,
> > to get rid of #1 we don't, we can just do it.
> To get rid of the "mv", you need something like .DELETE_ON_ERROR. But
> the "rm" in the second case has nothing to do with interrupted builds.
> It is is doing the same nothing that the ones you are getting rid of
> here are.
> I.e., I was suggesting to get rid of the "rm" call in the hunk I showed
> above, but leave the "mv" for the follow-on patch.
Ahh, I see. It's quite a bit more work, but sure, I can do that.
next prev parent reply other threads:[~2021-05-17 10:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 11:56 [PATCH v2 0/5] doc: asciidoc cleanups Felipe Contreras
2021-05-14 11:56 ` [PATCH v2 1/5] doc: refactor common asciidoc dependencies Felipe Contreras
2021-05-14 11:56 ` [PATCH v2 2/5] doc: improve " Felipe Contreras
2021-05-14 11:56 ` [PATCH v2 3/5] doc: remove unnecessary rm instances Felipe Contreras
2021-05-15 9:24 ` Jeff King
2021-05-15 12:04 ` Felipe Contreras
2021-05-17 8:53 ` Jeff King
2021-05-17 10:42 ` Felipe Contreras [this message]
2021-05-17 11:40 ` Jeff King
2021-05-14 11:56 ` [PATCH v2 4/5] doc: simplify Makefile using .DELETE_ON_ERROR Felipe Contreras
2021-05-14 11:56 ` [PATCH v2 5/5] doc: avoid using rm directly Felipe Contreras
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).