From: Felipe Contreras <felipe.contreras@gmail.com>
To: Firmin Martin <firminmartin24@gmail.com>,
Firmin Martin <firminmartin24@gmail.com>,
git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: RE: [PATCH 2/2] t: use test_config whenever possible
Date: Sat, 15 May 2021 15:15:46 -0500 [thread overview]
Message-ID: <60a02bf2f16a2_eacf52085@natae.notmuch> (raw)
In-Reply-To: <20210514065508.247044-2-firminmartin24@gmail.com>
Firmin Martin wrote:
> diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh
> index ed11569d8d..ff18263171 100755
> --- a/t/t5526-fetch-submodules.sh
> +++ b/t/t5526-fetch-submodules.sh
> @@ -418,7 +418,7 @@ test_expect_success "'fetch.recurseSubmodules=on-demand' overrides global config
> git fetch --recurse-submodules
> ) &&
> add_upstream_commit &&
> - git config --global fetch.recurseSubmodules false &&
> + test_config_global fetch.recurseSubmodules false &&
> head1=$(git rev-parse --short HEAD) &&
> git add submodule &&
> git commit -m "new submodule" &&
> @@ -429,11 +429,7 @@ test_expect_success "'fetch.recurseSubmodules=on-demand' overrides global config
> (
> cd downstream &&
> git config fetch.recurseSubmodules on-demand &&
Uhm:
test_config fetch.recurseSubmodules on-demand &&
> - git fetch >../actual.out 2>../actual.err
> - ) &&
> - git config --global --unset fetch.recurseSubmodules &&
> - (
> - cd downstream &&
> + git fetch >../actual.out 2>../actual.err &&
> git config --unset fetch.recurseSubmodules
Then the above line can be removed too.
> ) &&
> test_must_be_empty actual.out &&
> @@ -446,7 +442,7 @@ test_expect_success "'submodule.<sub>.fetchRecurseSubmodules=on-demand' override
> git fetch --recurse-submodules
> ) &&
> add_upstream_commit &&
> - git config fetch.recurseSubmodules false &&
> + test_config fetch.recurseSubmodules false &&
> head1=$(git rev-parse --short HEAD) &&
> git add submodule &&
> git commit -m "new submodule" &&
> @@ -457,11 +453,7 @@ test_expect_success "'submodule.<sub>.fetchRecurseSubmodules=on-demand' override
> (
> cd downstream &&
> git config submodule.submodule.fetchRecurseSubmodules on-demand &&
Ditto.
Very nice cleanup.
--
Felipe Contreras
next prev parent reply other threads:[~2021-05-15 20:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 6:55 [PATCH 1/2] t/README: document test_config Firmin Martin
2021-05-14 6:55 ` [PATCH 2/2] t: use test_config whenever possible Firmin Martin
2021-05-15 20:15 ` Felipe Contreras [this message]
2021-05-15 20:21 ` Felipe Contreras
2021-05-15 22:00 ` Firmin Martin
2021-05-14 7:02 ` [PATCH 1/2] t/README: document test_config Eric Sunshine
2021-05-15 14:43 ` Firmin Martin
2021-05-15 15:27 ` [PATCH v2 0/2] document test_config & use it whenever possible Firmin Martin
2021-05-15 15:27 ` [PATCH v2 1/2] t/README: document test_config Firmin Martin
2021-05-16 5:03 ` Bagas Sanjaya
2021-05-17 7:44 ` Firmin Martin
2021-05-15 15:27 ` [PATCH v2 2/2] t: use test_config whenever possible Firmin Martin
2021-05-16 5:02 ` Junio C Hamano
2021-05-17 6:08 ` Firmin Martin
2021-05-17 6:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a02bf2f16a2_eacf52085@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=firminmartin24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).