From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>, Felipe Contreras <felipe.contreras@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] CodingGuidelines: explicitly allow "local" for test scripts
Date: Wed, 05 May 2021 12:18:36 -0500 [thread overview]
Message-ID: <6092d36c6d1a8_1d245208a4@natae.notmuch> (raw)
In-Reply-To: <YJKo02fG/riIetpu@coredump.intra.peff.net>
Jeff King wrote:
> On Tue, May 04, 2021 at 10:59:02PM -0500, Felipe Contreras wrote:
> > Indeed. But it also probably doesn't meet many other needs. A quick
> > check shows 54 failed tests just on t0000-basic.sh. I don't think it's
> > something we should even consider.
>
> Yeah, we have visited this off and on over the years (links below).
> There are some modernized ksh variants that work OK (like mksh), but I
> think we've declared ksh93 as not worth it.
Just to clarify what was said on that thread: ksh93 is not a version.
There is at least ksh93u+ and ksh93v-, which are *completely* different.
--
Felipe Contreras
prev parent reply other threads:[~2021-05-05 17:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 4:10 [PATCH] CodingGuidelines: explicitly allow "local" for test scripts Junio C Hamano
2021-05-03 4:21 ` Eric Sunshine
2021-05-03 5:21 ` Junio C Hamano
2021-05-03 5:23 ` [PATCH v2] " Junio C Hamano
2021-05-03 9:01 ` Ævar Arnfjörð Bjarmason
2021-05-04 3:01 ` Junio C Hamano
2021-05-04 12:27 ` Ævar Arnfjörð Bjarmason
2021-05-04 12:50 ` Junio C Hamano
2021-05-04 15:09 ` Ævar Arnfjörð Bjarmason
2021-05-04 20:22 ` Felipe Contreras
2021-05-04 23:17 ` brian m. carlson
2021-05-04 23:55 ` Junio C Hamano
2021-05-05 0:08 ` Felipe Contreras
2021-05-05 1:58 ` brian m. carlson
2021-05-05 3:59 ` Felipe Contreras
2021-05-05 14:16 ` Jeff King
2021-05-05 17:18 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6092d36c6d1a8_1d245208a4@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).