From: Cornelius Weig <cornelius.weig@tngtech.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: bitte.keine.werbung.einwerfen@googlemail.com,
thomas.braun@virtuell-zuhause.de, john@keeping.me.uk,
git@vger.kernel.org
Subject: Re: [PATCH 4/7] completion: teach ls-remote to complete options
Date: Thu, 2 Feb 2017 10:40:53 +0100 [thread overview]
Message-ID: <603697da-c8e9-5644-e0f0-7ee265c069d8@tngtech.com> (raw)
In-Reply-To: <20170202014014.25878-1-szeder.dev@gmail.com>
On 02/02/2017 02:40 AM, SZEDER Gábor wrote:
>
>> ls-remote needs to complete remote names and its own options.
>
> And refnames, too.
Yes, right. However, do you think it is reasonable to complete remote
refnames? I don't think so, because it would mean we would have to run
ls-remote during completion -- and waiting for ls-remote could be quite
lengthy.
>> In
>> addition to the existing remote name completions, do also complete
>> the options --heads, --tags, --refs, and --get-url.
>
> Why only these four options and not the other four?
>
> There are eight options in total here, so there is really no chance
> for cluttered terminals, and all eight are mentioned in the synopsis.
My line of thought is the following:
--quiet: does not print anything and is therefore only useful for
scripting. Thus, there is no need to have it on the command line completion.
--exit-code: has no visible effect and is only useful for scripting.
--upload-pack: is really exotic. Nobody will ever use it without digging
deep in the manuals. Therefore, I think it's unnecessary to have the
option completable.
--symref: Should probably be added, thanks.
However, if you don't find my reasoning for omitting the three options
above conclusive, I have no problem including them.
next prev parent reply other threads:[~2017-02-02 9:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 22:57 [PATCH 0/7] completion bash: add more options and commands bitte.keine.werbung.einwerfen
2017-01-22 22:57 ` [PATCH 1/7] completion: teach options to submodule subcommands bitte.keine.werbung.einwerfen
2017-01-22 22:57 ` [PATCH 2/7] completion: add subcommand completion for rerere bitte.keine.werbung.einwerfen
2017-02-02 0:57 ` SZEDER Gábor
2017-02-02 9:16 ` Cornelius Weig
2017-01-22 22:57 ` [PATCH 3/7] completion: improve bash completion for git-add bitte.keine.werbung.einwerfen
2017-01-22 22:57 ` [PATCH 4/7] completion: teach ls-remote to complete options bitte.keine.werbung.einwerfen
2017-02-02 1:40 ` SZEDER Gábor
2017-02-02 9:40 ` Cornelius Weig [this message]
2017-02-02 16:57 ` Junio C Hamano
2017-01-22 22:57 ` [PATCH 5/7] completion: teach replace " bitte.keine.werbung.einwerfen
2017-01-22 22:57 ` [PATCH 6/7] completion: teach remote subcommands option completion bitte.keine.werbung.einwerfen
2017-02-02 1:37 ` SZEDER Gábor
2017-02-02 10:29 ` Cornelius Weig
2017-01-22 22:57 ` [PATCH 7/7] completion: recognize more long-options bitte.keine.werbung.einwerfen
2017-01-24 7:15 ` Johannes Sixt
2017-01-24 8:14 ` Cornelius Weig
2017-01-24 23:24 ` Junio C Hamano
2017-01-24 23:33 ` Cornelius Weig
2017-01-24 23:43 ` Stefan Beller
2017-01-25 0:11 ` Cornelius Weig
2017-01-25 0:21 ` Stefan Beller
2017-01-25 0:43 ` Cornelius Weig
2017-01-25 0:52 ` Re: Stefan Beller
2017-01-25 0:54 ` Re: Linus Torvalds
2017-01-25 1:32 ` Re: Eric Wong
2017-01-25 6:54 ` SubmittingPatches: drop temporal reference for PGP signing Philip Oakley
2017-01-25 22:38 ` Stefan Beller
2017-01-26 13:30 ` Cornelius Weig
2017-01-26 17:57 ` Stefan Beller
2017-01-26 18:18 ` Junio C Hamano
2017-01-26 20:58 ` Philip Oakley
2017-01-27 10:49 ` Cornelius Weig
2017-01-27 17:43 ` Junio C Hamano
2017-01-27 21:17 ` [PATCH v2 0/7] completion: recognize more long-options cornelius.weig
2017-01-27 21:17 ` [PATCH v2 7/7] " cornelius.weig
2017-01-31 22:17 ` SZEDER Gábor
2017-02-01 16:49 ` Cornelius Weig
2017-02-02 2:00 ` SZEDER Gábor
2017-02-02 10:40 ` Cornelius Weig
2017-01-31 22:42 ` [PATCH 3/7] completion: improve bash completion for git-add SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603697da-c8e9-5644-e0f0-7ee265c069d8@tngtech.com \
--to=cornelius.weig@tngtech.com \
--cc=bitte.keine.werbung.einwerfen@googlemail.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=szeder.dev@gmail.com \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).