From: Felipe Contreras <felipe.contreras@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
David Aguilar <davvid@gmail.com>, Seth House <seth@eseth.com>,
git@vger.kernel.org
Subject: Re: [PATCH v3] mergetool: add automerge configuration
Date: Thu, 17 Dec 2020 02:31:26 -0600 [thread overview]
Message-ID: <5fdb175e79748_d35b620823@natae.notmuch> (raw)
In-Reply-To: <769774cf-a55f-c9ba-c33d-233d070bb3f1@kdbg.org>
Johannes Sixt wrote:
> Am 17.12.20 um 06:45 schrieb Felipe Contreras:
> > It doesn't make sense to display easily-solvable conflicts in the
> > different views of all mergetools.
> >
> > Only the chunks that warrant conflict markers should be displayed.
> >
> > In order to unobtrusively do this, add a new configuration:
> > mergetool.autoMerge.
> >
> > See Seth House's blog post [1] for the idea, and the rationale.
> >
> > [1] https://www.eseth.org/2020/mergetools.html
> >
> > Original-idea-by: Seth House <seth@eseth.com>
> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> > ---
> > Documentation/config/mergetool.txt | 3 +++
> > git-mergetool.sh | 10 ++++++++++
> > t/t7610-mergetool.sh | 18 ++++++++++++++++++
> > 3 files changed, 31 insertions(+)
> >
> > diff --git a/Documentation/config/mergetool.txt b/Documentation/config/mergetool.txt
> > index 16a27443a3..43af7a96f9 100644
> > --- a/Documentation/config/mergetool.txt
> > +++ b/Documentation/config/mergetool.txt
> > @@ -61,3 +61,6 @@ mergetool.writeToTemp::
> >
> > mergetool.prompt::
> > Prompt before each invocation of the merge resolution program.
> > +
> > +mergetool.autoMerge::
> > + Automatically resolve conflicts that don't require user intervention.
>
> As I hinted in an earlier message, some tools do know how to deal with
> unconflicted changes. This should be a setting in the tool driver, not a
> user-visible setting.
It could be done in both. We first should find a mergetool that is
negatively affected by this, which WinMerge doesn't seem to be one of
them:
1. Before: https://snipboard.io/8JA5Oz.jpg
2. After: https://snipboard.io/HUXnOg.jpg
That's a positive effect after the patch.
--
Felipe Contreras
next prev parent reply other threads:[~2020-12-17 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 5:45 [PATCH v3] mergetool: add automerge configuration Felipe Contreras
2020-12-17 7:37 ` Johannes Sixt
2020-12-17 8:31 ` Felipe Contreras [this message]
2020-12-18 0:47 ` Junio C Hamano
2020-12-18 2:40 ` Felipe Contreras
2020-12-18 10:34 ` Junio C Hamano
2020-12-18 12:13 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fdb175e79748_d35b620823@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=seth@eseth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).