From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_WEB,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 4C4151F5AE for ; Sun, 16 May 2021 05:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232996AbhEPFEo (ORCPT ); Sun, 16 May 2021 01:04:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232769AbhEPFEn (ORCPT ); Sun, 16 May 2021 01:04:43 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E94ECC061573 for ; Sat, 15 May 2021 22:03:29 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id t30so2408343pgl.8 for ; Sat, 15 May 2021 22:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nJqnI/IbtTbtRb4SFKBzLWLjbyCuE1yRFPx8Y6eeIn8=; b=avAKveat+8trjhCybQPSpyvP+1zaT0Z84auvr3UY11sLb5FKp+NT0O2O6tlBxNI0r+ wl/sd5lMeeP2UN+EQ5urHP8KGvFPFYQgMUDMwzKybZfW0voF9TE2N2TnIMJd3Q5sql3x ri6AqapwqKXKstRCLVXZN6wf3/bw+OIWLtcaSF1GcoK5X17rcidEGF6kjXtRJeXE49bC VvDe2EKWmfQ8K1dreTiFWXZDu449mcRub86gCFJYhVSPzHmIFyRRu6pd+U2EeS1ap8eb k3I36QLaqLecsYkpQsOIZ7yroNwrL+VtlqaJRmiF2m6qDZ1wYbOrEe9m80TfF+zAQdGy eMdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nJqnI/IbtTbtRb4SFKBzLWLjbyCuE1yRFPx8Y6eeIn8=; b=jnCoWTUDnslIQWv9A+l/M8vXxXw9lCimkTwkZDJQCEHs+DDS1mMRr/nlj8bNT/Rwfu 60w8nUnyQlsxHpVEzLQ2F2T1hF9AJUS3UfVBrptf9mtk2w//spAoXmq1c9NIHIP+UTm3 wqhIYSiSrP2Rc7mxpq+jvKbopKLMTnD/N/DqWDNn25n8wX4rUzX6j9A89nhl+WldJ/C5 1O5DrdcuM69iNuro9dVZd+HcrOU2deQN5OB1mUbbHansQF+vrUq5DSPBOwpjunxxidpB D8aJSLLTDOy8yOD6QjI327HhQl8GtF+JAS4WbwqYW5qNvfEX+DaCiXUkW3qRpcHJBV6d Wi0g== X-Gm-Message-State: AOAM533F6no9skFVQMRd6IUqLi7iy2CIcMJyAEwzWJ132VAV6wTFhjgf 0FR5AeBbSKCwpwIiG6LLJaV2HY8PZ4Swqw== X-Google-Smtp-Source: ABdhPJw4RoCsf7cJD+YJFpB+jMYP2+C4y7qBJIuxoL75NV8mRMTgToNzYMjV3lkN73ujRvp9YZBk/Q== X-Received: by 2002:a65:618c:: with SMTP id c12mr54866312pgv.296.1621141409201; Sat, 15 May 2021 22:03:29 -0700 (PDT) Received: from [192.168.43.80] (subs32-116-206-28-61.three.co.id. [116.206.28.61]) by smtp.gmail.com with ESMTPSA id a16sm7003566pfc.37.2021.05.15.22.03.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 May 2021 22:03:28 -0700 (PDT) Subject: Re: [PATCH v2 1/2] t/README: document test_config To: Firmin Martin , git@vger.kernel.org Cc: Junio C Hamano , Eric Sunshine References: <20210514065508.247044-1-firminmartin24@gmail.com> <20210515152721.885728-1-firminmartin24@gmail.com> <20210515152721.885728-2-firminmartin24@gmail.com> From: Bagas Sanjaya Message-ID: <5faaa5a6-8ebf-b2ef-805f-551a36ab7e6c@gmail.com> Date: Sun, 16 May 2021 12:03:25 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210515152721.885728-2-firminmartin24@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 15/05/21 22.27, Firmin Martin wrote: > > + - test_config [] > + > + Set the configuration option to , and unset it at the > + end of the current test. For a similar purpose, test_config_global for > + global configuration is also available. Note, however, that test_config_* > + must not be used in a subshell. > + From the syntax above, when I omit , default value for will be set, right? You forgot to mention it. > + Example: > + > + test_config format.coverLetter auto > + > + Is a concise way to write: > + test_when_finished "git config --unset format.coverLetter" && > + git config format.coverLetter auto > + > The description said "set the config, then unset it". But the expanded version said "unsetting the config is deferred to the end of test and set the config". The documentation for test_when_finished said: > Prepend