From: "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Christian Couder [ ]" <chriscool@tuxfamily.org>,
"Junio C Hamano [ ]" <gitster@pobox.com>,
"Emily Shaffer [ ]" <nasamuffin@google.com>,
"Josh Steadmon [ ]" <steadmon@google.com>,
"Randall S. Becker [ ]" <rsbecker@nexbridge.com>,
"Christian Couder [ ]" <christian.couder@gmail.com>,
Kristoffer Haugsbakk
<"[code@khaugsbakk.name]"@web.codeaurora.org>,
Linus Arver <linusa@google.com>, Linus Arver <linusa@google.com>
Subject: [PATCH 2/5] format_trailer_info(): drop redundant unfold_value()
Date: Fri, 15 Mar 2024 06:55:02 +0000 [thread overview]
Message-ID: <5f9e444197468d065264b85c8cf7434df0e08070.1710485706.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1694.git.1710485706.gitgitgadget@gmail.com>
From: Linus Arver <linusa@google.com>
This is another preparatory refactor to unify the trailer formatters.
In the last patch we made format_trailer_info() use trailer_item objects
instead of the "trailers" string array. This means that the call to
unfold_value() here is redundant because the trailer_item objects are
already unfolded in parse_trailers() which is a dependency of our
caller, format_trailers_from_commit().
Remove the redundant call.
Signed-off-by: Linus Arver <linusa@google.com>
---
trailer.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/trailer.c b/trailer.c
index a74f05db55c..2c0dd8ac829 100644
--- a/trailer.c
+++ b/trailer.c
@@ -1101,9 +1101,6 @@ static void format_trailer_info(const struct process_trailer_options *opts,
strbuf_addstr(&val, item->value);
if (!opts->filter || opts->filter(&tok, opts->filter_data)) {
- if (opts->unfold)
- unfold_value(&val);
-
if (opts->separator && out->len != origlen)
strbuf_addbuf(out, opts->separator);
if (!opts->value_only)
--
gitgitgadget
next prev parent reply other threads:[~2024-03-15 7:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 6:55 [PATCH 0/5] Unify trailer formatting functions Linus Arver via GitGitGadget
2024-03-15 6:55 ` [PATCH 1/5] format_trailer_info(): use trailer_item objects Linus Arver via GitGitGadget
2024-03-15 6:55 ` Linus Arver via GitGitGadget [this message]
2024-03-15 6:55 ` [PATCH 3/5] format_trailer_info(): append newline for non-trailer lines Linus Arver via GitGitGadget
2024-03-15 17:22 ` Junio C Hamano
2024-03-15 6:55 ` [PATCH 4/5] trailer: begin formatting unification Linus Arver via GitGitGadget
2024-03-15 6:55 ` [PATCH 5/5] trailer: finish " Linus Arver via GitGitGadget
2024-03-15 17:20 ` [PATCH 0/5] Unify trailer formatting functions Junio C Hamano
2024-03-15 18:26 ` Kristoffer Haugsbakk
2024-03-15 19:10 ` Junio C Hamano
2024-03-15 21:36 ` Linus Arver
2024-03-15 21:43 ` Junio C Hamano
2024-03-26 21:57 ` Junio C Hamano
2024-04-02 0:27 ` Linus Arver
2024-04-15 21:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f9e444197468d065264b85c8cf7434df0e08070.1710485706.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc="[code@khaugsbakk.name]"@web.codeaurora.org \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linusa@google.com \
--cc=nasamuffin@google.com \
--cc=rsbecker@nexbridge.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).