From: Andrew Klotz <agc.klotz@gmail.com>
To: gitster@pobox.com
Cc: phillip.wood123@gmail.com, peff@peff.net, gitgitgadget@gmail.com,
git@vger.kernel.org, agc.klotz@gmail.com
Subject: Re: [PATCH 1/2] config: improve error message for boolean config
Date: Sat, 23 Jan 2021 18:15:56 -0500 [thread overview]
Message-ID: <5f00282b-2e65-929a-5331-df50c4a8d8cc@gmail.com> (raw)
Thanks for the feedback,
I updated the branch and moved:
- boolean error message change out of git_config_bool_or_int to just
in git_config_bool
- added die_bad_boolean instead of modifying die_bad_number.
The advantage here is we only use a bool error message when we know the
value
is a bool. Is this more along the lines of the suggestion?
next reply other threads:[~2021-01-23 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 23:15 Andrew Klotz [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-18 2:17 [PATCH 0/2] config: improve error message for boolean config Andrew Klotz via GitGitGadget
2020-09-18 2:17 ` [PATCH 1/2] " Andrew Klotz via GitGitGadget
2020-09-18 18:10 ` Jeff King
2020-09-18 18:30 ` Phillip Wood
2020-09-18 19:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f00282b-2e65-929a-5331-df50c4a8d8cc@gmail.com \
--to=agc.klotz@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
--cc=xmqqpn6ilwwx.fsf@gitster.c.googlers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).