From: Johannes Schindelin <johannes.schindelin@gmx.de> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com> Subject: [PATCH 03/11] remote: warn loud and clear when .git/branches/ is *still* used Date: Thu, 11 May 2017 15:47:43 +0200 (CEST) [thread overview] Message-ID: <5da6c76ca5f6805ad868b361b27ae61d8427819a.1494509599.git.johannes.schindelin@gmx.de> (raw) In-Reply-To: <cover.1494509599.git.johannes.schindelin@gmx.de> Since at least 5751f49010e (Move remote parsing into a library file out of builtin-push., 2007-05-12), we strongly prefer remotes and upstream branches to be specified in the config rather than .git/remotes/ and .git/branches/. For some time, we still retained compatibility with Cogito (which was an excellent project demonstrating many useful features that eventually were integrated into Git proper) by creating the branches/ subdirectory upon git-init. In preparation for removing support for this ancient compatibility that should no longer be necessary, let's warn everybody who is still using that feature (if there is anybody left, that is). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- remote.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/remote.c b/remote.c index 801137c72eb..04ab2230337 100644 --- a/remote.c +++ b/remote.c @@ -290,6 +290,9 @@ static void read_branches_file(struct remote *remote) return; } + warning(_("the branch '%s' uses the long-deprecated '%s' file"), + remote->name, git_path("branches/%s", remote->name)); + remote->configured_in_repo = 1; remote->origin = REMOTE_BRANCHES; -- 2.12.2.windows.2.800.gede8f145e06
next prev parent reply other threads:[~2017-05-11 13:48 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-11 13:47 [PATCH 00/11] Start retiring .git/remotes/ and .git/branches/ for good Johannes Schindelin 2017-05-11 13:47 ` [PATCH 01/11] git-parse-remote: fix highly misleading man page Johannes Schindelin 2017-05-11 17:21 ` Stefan Beller 2017-05-11 19:14 ` Johannes Schindelin 2020-11-11 15:17 ` [PATCH 0/5] Remove now-unused git-parse-remote Ævar Arnfjörð Bjarmason 2020-11-11 17:37 ` Jeff King 2020-11-11 19:29 ` Junio C Hamano 2020-11-12 14:09 ` Ævar Arnfjörð Bjarmason 2020-11-12 18:42 ` Jeff King 2020-11-12 14:19 ` How do I "git fetch" with a custom <refspec> but a default remote? Ævar Arnfjörð Bjarmason 2020-11-12 18:51 ` Jeff King 2020-11-12 19:26 ` Chris Torek 2020-11-12 20:48 ` Jeff King 2020-11-12 21:22 ` Junio C Hamano 2020-11-14 12:12 ` Ævar Arnfjörð Bjarmason 2020-11-11 15:17 ` [PATCH 1/5] parse-remote: remove unused GIT_DIR variable Ævar Arnfjörð Bjarmason 2020-11-11 15:17 ` [PATCH 2/5] parse-remote: remove long-dead rebase code Ævar Arnfjörð Bjarmason 2020-11-11 15:17 ` [PATCH 3/5] parse-remote: remove long-dead git-pull.sh code Ævar Arnfjörð Bjarmason 2020-11-11 15:17 ` [PATCH 4/5] parse-remote: move used code to git-submodule.sh Ævar Arnfjörð Bjarmason 2020-11-11 15:17 ` [PATCH 5/5] parse-remote: remove this now-unused library Ævar Arnfjörð Bjarmason 2020-11-11 16:33 ` Junio C Hamano 2020-11-12 20:31 ` [PATCH v2 0/2] Retire git-parse-remote Junio C Hamano 2020-11-12 20:31 ` [PATCH v2 1/2] parse-remote: move used code to git-submodule.sh Junio C Hamano 2020-11-12 20:31 ` [PATCH v2 2/2] parse-remote: remove this now-unused library Junio C Hamano 2020-11-12 20:49 ` [PATCH v2 0/2] Retire git-parse-remote Jeff King 2020-11-12 21:25 ` Junio C Hamano 2020-11-13 9:42 ` Ævar Arnfjörð Bjarmason 2020-11-14 12:21 ` [PATCH v3 0/3] submodule sh->C & retire parse-remote Ævar Arnfjörð Bjarmason 2020-11-14 12:21 ` [PATCH v3 1/3] submodule: use "fetch" logic instead of custom remote discovery Ævar Arnfjörð Bjarmason 2020-11-16 21:13 ` Junio C Hamano 2020-11-14 12:21 ` [PATCH v3 2/3] submodule: remove sh function in favor of helper Ævar Arnfjörð Bjarmason 2020-11-14 12:21 ` [PATCH v3 3/3] parse-remote: remove this now-unused library Ævar Arnfjörð Bjarmason 2020-11-16 21:19 ` Junio C Hamano 2020-11-17 14:24 ` Ævar Arnfjörð Bjarmason 2017-05-11 13:47 ` [PATCH 02/11] Documentation: really deprecate .git/remotes/ and .git/branches/ Johannes Schindelin 2017-05-11 13:47 ` Johannes Schindelin [this message] 2017-05-11 13:47 ` [PATCH 04/11] remote: warn loud and clear when .git/remotes/ is *still* used Johannes Schindelin 2017-05-11 13:47 ` [PATCH 05/11] Revert "Revert "Don't create the $GIT_DIR/branches directory on init"" Johannes Schindelin 2017-05-11 17:26 ` Stefan Beller 2017-05-11 13:47 ` [PATCH 06/11] PREVIEW: t5510: convert .git/remotes/ test to use a regular remote Johannes Schindelin 2017-05-11 13:47 ` [PATCH 07/11] PREVIEW: t5516: stop testing .git/branches/ functionality Johannes Schindelin 2017-05-11 13:47 ` [PATCH 08/11] PREVIEW: remote: remove support for migrating ancient remotes Johannes Schindelin 2017-05-11 13:48 ` [PATCH 09/11] PREVIEW: t5515: remove .git/remotes/ and .git/branches/ tests Johannes Schindelin 2017-05-11 13:48 ` [PATCH 10/11] PREVIEW: t0060: stop testing support for .git/remotes/ and .git/branches/ Johannes Schindelin 2017-05-11 13:48 ` [PATCH 11/11] PREVIEW: remove " Johannes Schindelin 2017-05-11 18:19 ` Stefan Beller 2017-05-11 19:19 ` Johannes Schindelin 2017-05-12 1:14 ` [PATCH 00/11] Start retiring .git/remotes/ and .git/branches/ for good Junio C Hamano 2017-05-12 10:18 ` Johannes Schindelin 2017-05-16 0:37 ` Junio C Hamano 2017-05-16 8:05 ` Ævar Arnfjörð Bjarmason 2017-05-16 9:06 ` Junio C Hamano 2017-05-16 10:02 ` Ævar Arnfjörð Bjarmason 2017-05-17 0:51 ` Junio C Hamano 2017-05-12 12:00 ` Junio C Hamano 2017-05-12 14:19 ` Johannes Schindelin 2017-05-12 17:38 ` Jonathan Nieder 2017-05-13 10:13 ` Junio C Hamano 2017-05-12 21:11 ` Junio C Hamano 2017-05-15 8:42 ` Johannes Schindelin 2017-05-12 9:11 ` Jeff King 2017-05-12 11:09 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5da6c76ca5f6805ad868b361b27ae61d8427819a.1494509599.git.johannes.schindelin@gmx.de \ --to=johannes.schindelin@gmx.de \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --subject='Re: [PATCH 03/11] remote: warn loud and clear when .git/branches/ is *still* used' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).